Enhance TypeScript types to leverage the true power of typechecking and intellisense #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! PRs are definitely welcome, I'll review this. |
|
you're welcome @jordaaash :) |
|
Hey @jordaaash any news on this by any chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed the library is written in TypeScript and it provides proper typings but it does not harvest the full potential of TS when it comes to intellisense and type checking.
As a matter of fact I wanted to do this cause I had one typo in my struct and it took me 2+ hours to find a mispelled key. This could've be avoided with this patch. Let me show what i mean
Untitled.mov
As shown in the video the with this patch the developer should be able to get the proper code completion (from TS service) as well as typechecking (as shown in the last segment of the video).
This patch also tackles the
encodemethod making sure the developer provides the correct object to encode. Ex:Working on the codebase i noticed other stuff i'd like to enhance but i'm not sure if pull requests are welcome...