Remove exclusion of dependancies #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because this package uses buffer
|
@jordansexton or @steveluscher: can you please look at this PR |
3 tasks
steveluscher
requested changes
Jan 9, 2023
There was a problem hiding this comment.
You're absolutely right that this directive is useless. Look at the docs for exclude:
Specifies an array of filenames or patterns that should be skipped when resolving include.
Given that definition, "exclude": ["node_modules"] should have no effect, right? node_modules/ is not a subdirectory of the include (src/). In any case, it doesn't belong.
Can you publish the repo where you're experiencing the error noted in MoralisWeb3/Moralis-JS-SDK#947? I want to make sure that this fixes your problem before publishing a new version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because this package uses buffer.
This creates problem like this.
MoralisWeb3/Moralis-JS-SDK#947