Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dos-run.sh: only require webhooks for scheduled runs #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

t-nelson
Copy link

@t-nelson t-nelson commented Mar 9, 2023

Problem

can't run bench-tps without reporting

Changes

only require hook(s) to be specified with SCHEDULED_RUN is set (already added to existing schedules)

@t-nelson t-nelson requested a review from pieceofr March 9, 2023 04:00
@pieceofr
Copy link
Contributor

pieceofr commented Mar 9, 2023

Could you please clarify the meaning of "SCHEDULED_RUN"? I'm confused about its usage as there's also a "SCHEDULED RUN" in Pipeline of Buildkite. Additionally, we have multiple places where we check the webhook for the report service. If we don't want to check webhooks, should we also disable the report process?

@t-nelson
Copy link
Author

t-nelson commented Mar 9, 2023

Could you please clarify the meaning of "SCHEDULED_RUN"? I'm confused about its usage as there's also a "SCHEDULED RUN" in Pipeline of Buildkite. Additionally, we have multiple places where we check the webhook for the report service. If we don't want to check webhooks, should we also disable the report process?

SCHEDULED_RUN is just another envvar that i added to the scheduled jobs on buildkite. idea is to signal to the script that the job is scheduled and only make webhooks a hard requirement in that case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants