Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure code #23

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Restructure code #23

merged 7 commits into from
Oct 8, 2024

Conversation

vgole001
Copy link
Contributor

@vgole001 vgole001 commented Oct 4, 2024

Relevant changes:

  • Linkchecker module replaced with requests module since not all links need to be checked
  • API schema changed
  • Parent table removed

@vgole001 vgole001 marked this pull request as draft October 4, 2024 06:55
@vgole001 vgole001 marked this pull request as ready for review October 4, 2024 10:02
pvgenuchten
pvgenuchten approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@pvgenuchten pvgenuchten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @vgole001, it will likely be much faster!

@pvgenuchten pvgenuchten merged commit f5fa4e4 into soilwise-he:main Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvgenuchten pvgenuchten pvgenuchten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgole001 @pvgenuchten @vgkoles