Implement more flows ops methods part 2 #75
Conversation
emil-bar
force-pushed
the
implement-more-flows-ops-methods-part-2
branch
3 times, most recently
from
c6e1454 to
f6c1fbb
Compare
* interleave * mapConcat * mapPar * mapParUnordered * sliding * alsoTo * alsoToTap
emil-bar
force-pushed
the
implement-more-flows-ops-methods-part-2
branch
from
f6c1fbb to
a9dc2b6
Compare
|
I assume these are directly translated from ox - any places where the implementations diverge? |
Yes, all of them are translated, including tests (I rely on them to see if implementation works). One additional thing is that for methods that use |
| * remaining non-completed flows. | ||
| */ | ||
| public static <T> Flow<T> interleaveAll(List<Flow<T>> flows, int segmentSize, boolean eagerComplete, int bufferCapacity) { |
There was a problem hiding this comment.
I must have created this method before adding scope value for buffer capacity. I'll overload the method in the next PR
Are these tests which verify what exception was thrown? Maybe we could instead change the tests to verify that an EE was thrown? EE are something that we might want to change in general (see #59), but until then, it would be good to keep consistency. |
Yes, those are the tests that verify it. I can fix the tests and verify that EE is thrown. Overall those exceptions are ugly as we are adding 2/3 wrappers on top of source exception in most cases |
|
@uini223 let's get rid of them in a separate issue then :) |
emil-bar
force-pushed
the
implement-more-flows-ops-methods-part-2
branch
from
977f78d to
2a4860a
Compare
Removed all rethrows that were present in the code I've added recently |
Closes #67