minor fixes after code review

softwaremill · Jan 24, 2025 · 1664efe · 1664efe
1 parent c73992c
commit 1664efe
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 15 deletions.
diff --git a/docs/stack.md b/docs/stack.md
@@ -17,10 +17,11 @@ Bootzooka's stack consists of the following technologies/tools, on the backend:
 
 And on the frontend:
 
+- [Vite](https://vite.dev/) (build tool)
 - [TypeScript](https://www.typescriptlang.org) (JavaScript superset)
 - [react](https://react.dev/)
 - [Swagger](https://swagger.io) (interactive API docs)
-- [yarn](https://yarnpkg.com) (build tool)
+- [yarn](https://yarnpkg.com) (package manager)
 - [formik](https://formik.org/) (forms)
 - [yup](https://www.npmjs.com/package/yup/v/1.3.3) (validation)
 - [openapi-codegen](https://github.com/fabien0102/openapi-codegen) (generate ui functions from OpenAPI specifications)

diff --git a/ui/src/main/Main/Main.tsx b/ui/src/main/Main/Main.tsx
@@ -1,19 +1,19 @@
 import { useContext } from 'react';
 import { UserContext } from 'contexts/UserContext/User.context';
-import useLoginOnApiKey from './useLoginOnApiKey';
-import useLocalStoragedApiKey from './useLocalStoragedApiKey';
 import { Top } from 'main/Top/Top';
 import { Footer } from 'main/Footer/Footer';
 import { Loader } from 'main/Loader/Loader';
 import { ForkMe } from 'main/ForkMe/ForkMe';
 import { Routes } from 'main/Routes/Routes';
+import useLoginOnApiKey from './useLoginOnApiKey';
+import useLocalStorageApiKey from './useLocalStorageApiKey';
 
 export const Main = () => {
   const {
     state: { loggedIn },
   } = useContext(UserContext);
 
-  useLocalStoragedApiKey();
+  useLocalStorageApiKey();
   useLoginOnApiKey();
 
   if (loggedIn === null) {

diff --git a/...main/Main/useLocalStoragedApiKey.test.tsx → .../main/Main/useLocalStorageApiKey.test.tsx b/...main/Main/useLocalStoragedApiKey.test.tsx → .../main/Main/useLocalStorageApiKey.test.tsx
@@ -4,14 +4,14 @@ import { render, screen } from '@testing-library/react';
 import { userEvent } from '@testing-library/user-event';
 import { UserContextProvider, UserAction } from 'contexts';
 import { UserContext } from 'contexts/UserContext/User.context';
-import useLocalStoragedApiKey from './useLocalStoragedApiKey';
+import useLocalStorageApiKey from './useLocalStorageApiKey';
 
 const TestComponent: React.FC<{ actions?: UserAction[]; label?: string }> = ({
   actions,
   label,
 }) => {
   const { state, dispatch } = useContext(UserContext);
-  useLocalStoragedApiKey();
+  useLocalStorageApiKey();
   return (
     <>
       <div>

diff --git a/ui/src/main/Main/useLocalStoragedApiKey.tsx → ui/src/main/Main/useLocalStorageApiKey.tsx b/ui/src/main/Main/useLocalStoragedApiKey.tsx → ui/src/main/Main/useLocalStorageApiKey.tsx
@@ -1,7 +1,7 @@
 import { useContext, useEffect, useRef } from 'react';
 import { UserContext } from 'contexts/UserContext/User.context';
 
-const useLocalStoragedApiKey = () => {
+const useLocalStorageApiKey = () => {
   const {
     dispatch,
     state: { apiKey, loggedIn },
@@ -34,4 +34,4 @@ const useLocalStoragedApiKey = () => {
   }, [loggedIn]);
 };
 
-export default useLocalStoragedApiKey;
+export default useLocalStorageApiKey;
diff --git a/ui/src/pages/Profile/components/ProfileDetails.validations.ts b/ui/src/pages/Profile/components/ProfileDetails.validations.ts
@@ -5,6 +5,6 @@ export const validationSchema = Yup.object({
     .min(3, 'At least 3 characters required')
     .required('Required'),
   email: Yup.string()
-    .email('Correct email address required')
+    .email('Valid email address required')
     .required('Required'),
 });
diff --git a/ui/src/pages/Register/Register.validations.ts b/ui/src/pages/Register/Register.validations.ts
@@ -5,7 +5,7 @@ export const validationSchema = Yup.object({
     .min(3, 'At least 3 characters required')
     .required('Required'),
   email: Yup.string()
-    .email('Correct email address required')
+    .email('Valid email address required')
     .required('Required'),
   password: Yup.string()
     .min(5, 'At least 5 characters required')

diff --git a/ui/tsconfig.app.json b/ui/tsconfig.app.json
@@ -8,22 +8,19 @@
     "module": "ESNext",
     "skipLibCheck": true,
 
-    /* Bundler mode */
     "moduleResolution": "bundler",
     "allowImportingTsExtensions": true,
     "isolatedModules": true,
     "moduleDetection": "force",
     "noEmit": true,
     "jsx": "react-jsx",
 
-    /* Linting */
     "strict": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noFallthroughCasesInSwitch": true,
     "noUncheckedSideEffectImports": true,
 
-    /* Path aliasses */
     "paths": {
       "api/*": ["./src/api/*"],
       "assets/*": ["./src/assets/*"],

diff --git a/ui/tsconfig.node.json b/ui/tsconfig.node.json
@@ -6,14 +6,12 @@
     "module": "ESNext",
     "skipLibCheck": true,
 
-    /* Bundler mode */
     "moduleResolution": "bundler",
     "allowImportingTsExtensions": true,
     "isolatedModules": true,
     "moduleDetection": "force",
     "noEmit": true,
 
-    /* Linting */
     "strict": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,