Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: APP-1186 added maker checker for agency paas project needs (approve, reject, discard etc) #232

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

luhfluh
Copy link

@luhfluh luhfluh commented Jun 1, 2022

ut-rule changes to add maker checker for agency paas project needs

@luhfluh luhfluh requested a review from kalinkrustev June 1, 2022 08:30
@luhfluh luhfluh changed the title Paas/app 1186 chore: APP-1186 added maker checker for agency paas project needs (approve, reject, discard etc) Jun 1, 2022
api/script/index.js Outdated Show resolved Hide resolved
api/sql/schema/750-rule.rule.fetch.sql Outdated Show resolved Hide resolved
api/sql/schema/750-rule.rule.fetch.sql Outdated Show resolved Hide resolved
@kalinkrustev
Copy link
Member

@venetahristova @tuncheto , you may want to have a look and share comments about this. It will be good to have some tests and DB review before we accept it.

@tuncheto
Copy link
Contributor

tuncheto commented Jun 2, 2022

I see only add, we don't need maker/checker for edit or it is not implemented yet?

@raymondadutwumagyei
Copy link

I see only add, we don't need maker/checker for edit or it is not implemented yet?

@tuncheto @kalinkrustev @venetahristova Am still working on edit, lock/unlock and delete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants