-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pixel 8 and 9 skins #601
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0c292f0
to
5656135
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, I didn't have this issue |
This PR fixes pixel 9 mask issue and adds formating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve, but please let @p-malecki take a look before merging, as he is currently working on devices names, and I am not sure if the name you use will still exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @filip131311 mentioned in the last comment, I am working on PR #597 in which we add the option for users to set and change device display names. In that PR, I use displayName for storing the user's custom device name and deviceName for detecting the device type and determining whether it is supported. There are some differences in the way you use them in this PR, but I think it's best to accept it as is and make changes later in #597.
I left some comments but you do not have to address them, they are changes that I intend to implement in #597.
Resolves #583
Screenshots
Pixel 8
Pixel 9