Add Pixel 8 and 9 skins #601
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
km1chno
force-pushed
the
@km1chno/add-pixel-8-and-9
branch
from
0c292f0
to
5656135
Compare
|
Also It seems that the system does not know on what device it is run |
|
interesting, I didn't have this issue |
This PR fixes pixel 9 mask issue and adds formating
There was a problem hiding this comment.
I approve, but please let @p-malecki take a look before merging, as he is currently working on devices names, and I am not sure if the name you use will still exist.
There was a problem hiding this comment.
As @filip131311 mentioned in the last comment, I am working on PR #597 in which we add the option for users to set and change device display names. In that PR, I use displayName for storing the user's custom device name and deviceName for detecting the device type and determining whether it is supported. There are some differences in the way you use them in this PR, but I think it's best to accept it as is and make changes later in #597.
I left some comments but you do not have to address them, they are changes that I intend to implement in #597.
Resolves #583
Screenshots
Pixel 8
Pixel 9