Change User instead of Workspace settings. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 28, 2024 18:09
|
Someone is attempting to deploy this pull request to the software-mansion Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
kmagiera
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Not a fan of this API as it makes it difficult to understand what this parameter do w/o looking at vscode documentation.
Would be better if update method was named sth like updateUserLevel which would clearly indicate that the update is happening on user level. It seems like for now we can just rename the current update method, as we only have one setting so no point in adding extra unused abstraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
using our dropdown menu to change Location configuration would change them only in workspace scope, which could cause confusion, after changing projects.
After:
dropdown menu changes global configuration.