Fix for error message when reloading iOS application during build #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy this pull request to the software-mansion Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
kmagiera
reviewed
Mar 25, 2024
Comment on lines
373
to
376
| if (/Command was killed with SIGKILL \(Forced termination\): xcodebuild/.exec(e.message)) { | ||
| Logger.debug(e); | ||
| return; | ||
| } |
There was a problem hiding this comment.
instead of this add extra check to the if block below to verify if this.deviceSession === newDeviceSession
also in line 324 do:
const prevSession = this.deviceSession;
this.deviceSession= undefined;
prevSession?.dispose();
kmagiera
approved these changes
Mar 25, 2024
added 2 commits
March 25, 2024 15:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a primitive fix of a problem with reloading on iOS during build.
Before:
When reloading when subprocess running
xcodebuildwas active the information about that process being killed would leak and cause change inProjectState.statustobuildErrordespite the fact that new build was up and running.After: this change prevents unwanted change in status, when it is caused by previous session
Fixes: #8