Skip to content

Commit

Permalink
Don't update shared prefs for expo go (#379)
Browse files Browse the repository at this point in the history
We recently added code that'd write to shaed prefs in order to disable
dev menu popping up on expo dev client on Android. This apparently
doesn't work with expo go, as the go APK installed on the emulator is
not debuggable. In this PR we add a check for the bundle name before we
write the setting.
  • Loading branch information
kmagiera authored Jun 13, 2024
1 parent 41b3782 commit e44e639
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,10 @@ export class AndroidEmulatorDevice extends DeviceBase {
}

async configureExpoDevMenu(packageName: string) {
if (packageName === "host.exp.exponent") {
// For expo go we are unable to change this setting as the APK is not debuggable
return;
}
// this code disables expo devmenu popup when the app is launched. When dev menu
// is displayed, it blocks the JS loop and hence react devtools are unable to establish
// the connection, and hence we never get the app ready event.
Expand Down

0 comments on commit e44e639

Please sign in to comment.