enhance: reuse thread pool for scheduled service #1389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvenLjj
reviewed
Jan 16, 2024
| @Extension("reuse-scheduled") | ||
| public class ReuseScheduledThreadPoolFactory implements SofaExecutorFactory { | ||
|
|
||
| Map<String, Executor> uniqueMap = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
最好设置成私有的，另外也要考虑下如何回收这里的Executor。
| * @author junyuan | ||
| * @version ReuseScheduledThreadPoolFactory.java, v 0.1 2024-01-15 19:44 junyuan Exp $ | ||
| */ | ||
| @Extension("reuse-scheduled") |
There was a problem hiding this comment.
容易和 BoltServer 中的处理线程混淆，RPC 中有很多的其他异步线程，是否可以考虑一下，其他异步线程也做个 Extension 或者单独搞个类管理这种线程池。
|
|
||
| @Override | ||
| public Executor createExecutor(String namePrefix, ServerConfig serverConfig) { | ||
| return uniqueMap.computeIfAbsent(namePrefix, key -> new ScheduledThreadPoolExecutor(1, new NamedThreadFactory(namePrefix, true))); |
There was a problem hiding this comment.
之前 coreSize 设置为 1，每个 Consumer 一个 Schedule 单一线程。 更换成共享一个 Schedule 线程池的话，如果还是使用单一线程的话，会不会存在性能问题和更新不及时的问题？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It might be exhausted when create new executor pool for some scheduled cases such as reconnection, where each consumer may has its own scheduled executor pool and its own thread. Amount of threads may grow to O(m) aligns with amount of consumers.
Modification:
add a reused schedule pool that may provide same pool with same unique key
Result: