Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dep fury #1387

Merged
merged 2 commits into from
Jan 12, 2024
Merged

add dep fury #1387

merged 2 commits into from
Jan 12, 2024

Conversation

Lo1nt
Copy link
Collaborator

@Lo1nt Lo1nt commented Jan 11, 2024

Motivation:

add fury to all

refactor fury ser api

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@sofastack-cla sofastack-cla bot added cla:yes CLA is ok size/S labels Jan 11, 2024
@Lo1nt Lo1nt requested a review from EvenLjj January 11, 2024 09:03
@sofastack-cla sofastack-cla bot added size/M and removed size/S labels Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (9faa8b8) 72.04% compared to head (cc36cbd) 72.02%.
Report is 2 commits behind head on master.

Files Patch % Lines
...va/com/alipay/sofa/rpc/server/bolt/BoltServer.java 53.06% 16 Missing and 7 partials ⚠️
.../sofa/rpc/dynamic/DynamicConfigManagerFactory.java 0.00% 6 Missing ⚠️
...ava/com/alipay/sofa/rpc/server/UserThreadPool.java 75.00% 2 Missing and 2 partials ⚠️
...sofa/rpc/common/threadpool/ThreadPoolConstant.java 0.00% 1 Missing ⚠️
...threadpool/extension/VirtualThreadPoolFactory.java 50.00% 1 Missing ⚠️
.../alipay/sofa/rpc/server/UserVirtualThreadPool.java 83.33% 1 Missing ⚠️
...a/com/alipay/sofa/rpc/event/LookoutSubscriber.java 66.66% 0 Missing and 1 partial ⚠️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1387      +/-   ##
============================================
- Coverage     72.04%   72.02%   -0.03%     
  Complexity      785      785              
============================================
  Files           417      421       +4     
  Lines         17709    17782      +73     
  Branches       2760     2770      +10     
============================================
+ Hits          12759    12807      +48     
- Misses         3546     3561      +15     
- Partials       1404     1414      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lo1nt Lo1nt requested a review from chuailiwu January 12, 2024 06:35
Copy link
Collaborator

@chuailiwu chuailiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lo1nt Lo1nt merged commit f48412c into sofastack:master Jan 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants