-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fury serializer #1348
add fury serializer #1348
Conversation
Hi @pandalee99, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
this error in :
But I haven't touched this module, so there shouldn't be an error. Why? I don't understand. |
The unit test is a bit unstable, it needs to be addressed later, for now let's try to solve it with a retry. |
maybe,this can be review or approve |
codec/codec-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/FurySerializer.java
Outdated
Show resolved
Hide resolved
codec/codec-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/FurySerializer.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1348 +/- ##
============================================
- Coverage 72.01% 71.99% -0.03%
Complexity 784 784
============================================
Files 416 417 +1
Lines 17661 17709 +48
Branches 2752 2760 +8
============================================
+ Hits 12719 12750 +31
- Misses 3538 3554 +16
- Partials 1404 1405 +1 ☔ View full report in Codecov by Sentry. |
...odec-fury/src/main/resources/META-INF/services/sofa-rpc/com.alipay.sofa.rpc.codec.Serializer
Outdated
Show resolved
Hide resolved
codec/codec-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/FuryHelper.java
Outdated
Show resolved
Hide resolved
codec/codec-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/FuryHelper.java
Outdated
Show resolved
Hide resolved
codec/codec-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/FuryHelper.java
Outdated
Show resolved
Hide resolved
codec/codec-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/FurySerializer.java
Outdated
Show resolved
Hide resolved
codec/codec-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/FurySerializer.java
Outdated
Show resolved
Hide resolved
codec/codec-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/FurySerializer.java
Outdated
Show resolved
Hide resolved
codec/codec-fury/src/main/java/com/alipay/sofa/rpc/codec/fury/FuryHelper.java
Outdated
Show resolved
Hide resolved
# Conflicts: # codec/codec-fury/src/test/java/com/alipay/sofa/rpc/codec/fury/FuryHelperTest.java
Motivation:
i try to add a serializer to the project. Combined with the cases provided by the project, I tried to combine them together
Modification:
the style of the code borrows from other style of the serializers.
In the project ,there is also a test case attached.
Result:
Fixes #1346 .
If there are any problems with the code, please give me a hint. thanks!