Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fury serializer #1348

Merged
merged 41 commits into from
Jan 8, 2024
Merged

add fury serializer #1348

merged 41 commits into from
Jan 8, 2024

Conversation

pandalee99
Copy link
Contributor

@pandalee99 pandalee99 commented Jul 19, 2023

Motivation:

i try to add a serializer to the project. Combined with the cases provided by the project, I tried to combine them together

Modification:

the style of the code borrows from other style of the serializers.
In the project ,there is also a test case attached.

Result:

Fixes #1346 .

If there are any problems with the code, please give me a hint. thanks!

@sofastack-cla
Copy link

sofastack-cla bot commented Jul 19, 2023

Hi @pandalee99, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@sofastack-cla sofastack-cla bot added cla:no Need sign CLA First-time contributor First-time contributor size/XL and removed First-time contributor First-time contributor size/XL labels Jul 19, 2023
@sofastack-cla sofastack-cla bot added cla:yes CLA is ok and removed cla:no Need sign CLA labels Jul 20, 2023
@pandalee99
Copy link
Contributor Author

this error in :

[INFO] sofa-rpc-test-integration .......................... FAILURE [06:21 min]

But I haven't touched this module, so there shouldn't be an error. Why? I don't understand.

@EvenLjj
Copy link
Collaborator

EvenLjj commented Jul 21, 2023

The unit test is a bit unstable, it needs to be addressed later, for now let's try to solve it with a retry.

@pandalee99
Copy link
Contributor Author

maybe,this can be review or approve

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (1e99afb) 72.01% compared to head (e373752) 71.99%.

Files Patch % Lines
.../rpc/codec/common/BlackAndWhiteListFileLoader.java 47.05% 16 Missing and 2 partials ⚠️
.../com/alipay/sofa/rpc/codec/AbstractSerializer.java 71.42% 1 Missing and 1 partial ⚠️
...ay/sofa/rpc/codec/common/SerializeCheckStatus.java 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1348      +/-   ##
============================================
- Coverage     72.01%   71.99%   -0.03%     
  Complexity      784      784              
============================================
  Files           416      417       +1     
  Lines         17661    17709      +48     
  Branches       2752     2760       +8     
============================================
+ Hits          12719    12750      +31     
- Misses         3538     3554      +16     
- Partials       1404     1405       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenLjj EvenLjj added this to the 5.11.0 milestone Jul 28, 2023
codec/codec-fury/pom.xml Outdated Show resolved Hide resolved
@sofastack-cla sofastack-cla bot added size/XXL and removed size/XL labels Aug 23, 2023
bom/pom.xml Outdated Show resolved Hide resolved
@EvenLjj EvenLjj closed this Nov 6, 2023
@EvenLjj EvenLjj reopened this Nov 6, 2023
@EvenLjj EvenLjj added the later This will be worked on in later version label Nov 27, 2023
@EvenLjj EvenLjj modified the milestones: 5.11.0, 5.12.0 Nov 30, 2023
@sofastack-cla sofastack-cla bot added size/XL and removed size/XXL labels Jan 2, 2024
@sofastack-cla sofastack-cla bot added size/XXL and removed size/XL labels Jan 3, 2024
@EvenLjj EvenLjj merged commit 7980b1f into sofastack:master Jan 8, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes CLA is ok later This will be worked on in later version size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SOFARPC 支持 Fury 序列化方式
4 participants