Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community contact way #1313

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

CrazyHZM
Copy link
Contributor

@CrazyHZM CrazyHZM commented Apr 26, 2024

Summary by CodeRabbit

  • Documentation
    • Updated the contact information section in the README to replace QR codes with a direct text link for community engagement.

Copy link

coderabbitai bot commented Apr 26, 2024

Walkthrough

The update simplifies the contact process for the SOFABoot project by replacing QR code images with a direct text link in the README.md. This change makes accessing community contact information more straightforward and text-based.

Changes

File Changes
README.md Replaced QR code images with a text link for community contact information.

🐰✨📖
In the realm of code, where the rabbits hop,
A simple link replaces the QR crop.
No more scans, just a click will do,
Hop along, join the chat, we welcome you!
🥕🎉


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 31d8f6f and 12cc67e.
Files selected for processing (1)
  • README.md (1 hunks)
Additional Context Used
LanguageTool (48)
README.md (48)

Near line 1: Possible spelling mistake found.
Context: ## SOFABoot ![build](https://github.com/sofastack/...


Near line 11: Possible spelling mistake found.
Context: ...sofa-boot.svg) 中文版本 SOFABoot is an open source Java development fram...


Near line 12: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ... 中文版本 SOFABoot is an open source Java development framework based on Spr...


Near line 15: Possible spelling mistake found.
Context: .... are provided out of box. In addition, SOFABoot accommodates SOFAStack middlewares more...


Near line 15: Possible spelling mistake found.
Context: ...box. In addition, SOFABoot accommodates SOFAStack middlewares more comfortably and seamle...


Near line 25: Possible spelling mistake found.
Context: ... of Spring Boot, Ant Group develops the SOFABoot based on Spring Boot and make it open s...


Near line 26: Possible spelling mistake found.
Context: ...Spring Boot and make it open source. In SOFABoot, SOFAStack middleware SDKs are packaged...


Near line 26: Possible spelling mistake found.
Context: ...t and make it open source. In SOFABoot, SOFAStack middleware SDKs are packaged as self-co...


Near line 28: Consider adding a comma here.
Context: ...tionality dependencies. ## Quick Start Please refer to SOFAStack Documentation for [S...


Near line 29: Possible spelling mistake found.
Context: ...ncies. ## Quick Start Please refer to SOFAStack Documentation for [SOFABoot quick start...


Near line 29: Possible spelling mistake found.
Context: ...e refer to SOFAStack Documentation for [SOFABoot quick start guide](https://www.sofastac...


Near line 32: Possible spelling mistake found.
Context: ...ofa-boot/quick-start/). ### Demos Some SOFABoot demo projects to get your hands dirty: ...


Near line 39: Possible spelling mistake found.
Context: ...production environment for Spring Boot, SOFABoot offers following enhancements: ### Rea...


Near line 44: Possible spelling mistake found.
Context: ...utomation in production environment and SOFABoot provides the readiness check for applic...


Near line 45: Possible spelling mistake found.
Context: .... For reliable application startup, all SOFAStack middleware services won't reveal themse...


Near line 50: Possible spelling mistake found.
Context: ...o solve class or dependency conflicts, SOFAArk...


Near line 51: Possible spelling mistake found.
Context: ...ark) is created. Compared with unwieldy OSGi class isolation implementation, SOFAArk...


Near line 51: Possible spelling mistake found.
Context: ...dy OSGi class isolation implementation, SOFAArk is a light-weight scheme and focuses on...


Near line 52: Possible spelling mistake found.
Context: ... is easy to make a third party SDK into SOFAArk module because the high extensibility o...


Near line 52: Possible spelling mistake found.
Context: ...odule because the high extensibility of SOFAArk. See further on [SOFAArk documentation...


Near line 54: Possible spelling mistake found.
Context: ...ensibility of SOFAArk. See further on [SOFAArk documentation](https://www.sofastack.te...


Near line 58: Possible spelling mistake found.
Context: ...va projects and packaged into different JARs. All Java classes are loaded by same cl...


Near line 58: Possible spelling mistake found.
Context: ...Rs. All Java classes are loaded by same classloader when running. 2. Modularization based o...


Near line 59: Possible spelling mistake found.
Context: ...hen running. 2. Modularization based on classloader: each module has its own classloader an...


Near line 59: Possible spelling mistake found.
Context: ...on classloader: each module has its own classloader and classpath between different modules...


Near line 59: Possible spelling mistake found.
Context: ...each module has its own classloader and classpath between different modules differs. SOF...


Near line 60: Possible spelling mistake found.
Context: ...ath between different modules differs. SOFABoot supplies a third option with degree of ...


Near line 62: It seems that the correct verb form here is “own”.
Context: ... upon Spring Context. Different modules owns by itself a distinct Spring Context and...


Near line 66: Possible spelling mistake found.
Context: ...educed effectively. More details about SOFABoot modularization are introduced in this [...


Near line 69: Consider a shorter alternative to avoid wordiness.
Context: ...s are basically the same in most cases. In order to save the repeated configuration, SOFABo...


Near line 70: Possible spelling mistake found.
Context: ...der to save the repeated configuration, SOFABoot utilizes the [sofa-common-tools](https:...


Near line 70: The plural noun “SDKs” doesn’t fit after the quantifier “each”. A possessive apostrophe may be missing, or you meant the singular form.
Context: .../sofa-common-tools) to provide for each SDKs basic log configurations. Users don't n...


Near line 71: Possible spelling mistake found.
Context: ...ations. Users don't need to worry about SDk logging anymore. Besides, every SDK has...


Near line 74: Possible spelling mistake found.
Context: ...toring based on logging. ### Built-in SOFAStack Middlewares Based on the auto-configuri...


Near line 75: This word is normally spelled as one.
Context: ...t-in SOFAStack Middlewares Based on the auto-configuring and dependencies descriptor (aka starte...


Near line 75: Possible spelling mistake found.
Context: ...escriptor (aka starter) in Spring Boot, SOFABoot offers easy-to-use programming interfac...


Near line 75: Possible spelling mistake found.
Context: ...sy-to-use programming interface for all SOFAStack middlewares. All of them are packaged a...


Near line 79: To make your writing clearer, consider a more direct alternative.
Context: ...Before taking any further steps, please take a look at [Contributing to SOFABoot](./CO...


Near line 79: Possible spelling mistake found.
Context: ... please take a look at Contributing to SOFABoot. SOFABoot is compi...


Near line 80: Possible spelling mistake found.
Context: ...uting to SOFABoot](./CONTRIBUTING.md). SOFABoot is compiled under JDK 17 currently and ...


Near line 87: Unpaired symbol: ‘]’ seems to be missing
Context: ...aster/ROLES-EN.md). ### Contact Us See [Community contact way](https://www.sofas...


Near line 90: The phrase ‘lots of’ might be wordy and overused. Consider using an alternative.
Context: ...ersion of SOFA is created by Felix(阿玺), lots of thanks are given to Felix for laying a ...


Near line 91: Consider using a different adverb to strengthen your wording.
Context: ...a solid foundation for SOFA. It is also very grateful to the people who have contrib...


Near line 93: Did you mean “and”?
Context: ...des in the history of SOFA. ## License Ant Group SOFABoot is distributed under the...


Near line 94: Possible spelling mistake found.
Context: ... history of SOFA. ## License Ant Group SOFABoot is distributed under the [Apache Licens...


Near line 95: Possible spelling mistake found.
Context: ...icenses of third parity dependencies of SOFABoot are explained [here](https://www.sofast...


Near line 98: Possible spelling mistake found.
Context: ...sofa-boot/notice/). ## Known Users The SOFABoot users (the names are in no particular o...


Near line 98: Possible spelling mistake found.
Context: ...ues/5) to tell us your scenario to make SOFABoot better.

<img alt="蚂蚁集团" src="http...

Additional comments not posted (1)
README.md (1)

87-87: Ensure the URL in the new contact link is correct and functional.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.15%. Comparing base (2ad93e1) to head (12cc67e).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1313      +/-   ##
============================================
+ Coverage     83.14%   83.15%   +0.01%     
  Complexity     2961     2961              
============================================
  Files           337      337              
  Lines          9707     9707              
  Branches       1168     1168              
============================================
+ Hits           8071     8072       +1     
  Misses         1127     1127              
+ Partials        509      508       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HzjNeverStop HzjNeverStop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit 9e2b142 into sofastack:master Apr 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants