Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Use data generator in marginal cumulative incidence example #62

Merged
merged 6 commits into from
Jul 4, 2024
Merged

DOC Use data generator in marginal cumulative incidence example #62

merged 6 commits into from
Jul 4, 2024

Conversation

ArturoAmorQ
Copy link

The present PR aims to simplifying the current Estimating marginal cumulative incidence functions example by using the make_synthetic_competing_weibull function instead of creating the datasets on the fly.

@ogrisel
Copy link
Contributor

ogrisel commented Jul 4, 2024

Oops I made a mistake by merging main here. I wanted to trigger the doc CI but this did not go as planned. Let me try to undo this merge commit.

ogrisel
ogrisel approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Arturo.

@ArturoAmorQ
Copy link
Author

LGTM. Thanks Arturo.

Thanks to you! Your improvements to my PR also LGTM 😬

@ogrisel ogrisel merged commit 5efd0ee into soda-inria:multi-incidence Jul 4, 2024
9 checks passed
@ArturoAmorQ ArturoAmorQ deleted the use_data_generator branch July 4, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArturoAmorQ @ogrisel