Move to General Purpose Allocator #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
booniepepper
commented
Jul 31, 2023
src/interpret.zig
Outdated
| @@ -358,7 +370,7 @@ pub const DtVal = union(enum) { | |||
|
|
|||
| pub fn intoQuote(self: DtVal, state: *DtMachine) !Quote { | |||
| return switch (self) { | |||
| .quote => |q| _deepClone(q, state), | |||
There was a problem hiding this comment.
TODO: Must add tests to ensure this is actually safe. Hopefully simple tests of def and dup and others will sort out exactly where things should be cloned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to a GeneralPurposeAllocator
This means dt needs to be freeing/destroying where appropriate
std.testing.allocatorstd.testing.allocatorCloses #1