Support mixed-mode rx #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Split into 2 cleaner PRs, so closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If RX worker is set to use_protobuf and receives an xml cot event, parse the xml.
Currently
xml2protoreturns the protocol bytes, i.e. meant for transmitting. This PR refactors axml2messagefunction that both sending (xml2proto) and receiving (parse_proto) can use to convert xml to TakMessage. Granted, a client could usexml2messagedirectly, but it is pretty smooth with pytak's current RXWorker to just send any received bytes toparse_proto().Also, I added support for timestamps that don't have subseconds, which I've seen a lot of in production environments.