Add filterWithKey and bump classyprelude cabal version #232
Conversation
|
@L0neGamer Please add to mono-traversable/ChangeLog.md |
|
@gregwebs When working with snoyberg on PRs he did not have me up the prelude versions when functionality was added to mono-traversable. What is your opinion on this? Considering that ClassyPrelude.hs imports with hiding it does not make sense to me to up the version if the dependencies export more. |
|
yeah classy prelude only needs to be bumped if it is exporting new things. |
|
The version of classy-prelude should remain unchanged. |
|
the version is unchanged, I used the wrong language; the cabal file was updated because stack was run at some point. |
|
@L0neGamer #234 fixed the classy-prelude cabal version. Try rebasing on master and ensure that classy-prelude/classy-prelude.cabal is unchanged and this should be ready to pull. |
…terWithKey, add better definitions of filterWithKey to instances in file snoyberg#218
|
@L0neGamer Thanks for the help! |
## 1.0.21.0 * Support for vector 0.13.2.0, adding instances for [`Data.Vector.Strict`](https://hackage.haskell.org/package/vector-0.13.2.0/docs/Data-Vector-Strict.html) data structure. [#244](snoyberg/mono-traversable#244) ## 1.0.20.0 * Added instances for [`Reverse`](https://hackage.haskell.org/package/transformers-0.6.1.1/docs/Data-Functor-Reverse.html#t:Reverse) data structure. ## 1.0.19.1 * Removed 'highly experimental' warning haddock comment from Data.Containers. ## 1.0.19.0 * Added `filterWithKey` to `IsMap`. [#232](snoyberg/mono-traversable#232) ## 1.0.18.0 * Added MonoPointed instance for text Builder [#225](snoyberg/mono-traversable#225)
closes #218
also adding dist-newstyle to the gitignore list
@BebeSparkelSparkel