Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An example app that listens on the PORT system variable #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tkvogt
Copy link

@tkvogt tkvogt commented Mar 28, 2021

A lot of people want to quickly see if it works.
With this patch you just have to copy paste a line of bash and copy the generated bundle to /opt/keter/incoming and go to https://localhost

@jappeace
Copy link
Collaborator

jappeace commented Nov 3, 2021

Adding a servant example is probably a good idea, but how is this different from the examples in: https://github.com/snoyberg/keter/tree/master/incoming

Also rebase onto master to make ci pass

@tkvogt
Copy link
Author

tkvogt commented Nov 3, 2021

I was not aware that there are examples in the incoming folder. What is not good in my opinion is to say in the Readme: "Modify your web app to check for the PORT environment variable" and not saying how. I will update this pull request.

@jappeace
Copy link
Collaborator

jappeace commented Nov 3, 2021

I added an explicit link to that: #224

Your example is still welcome, it'd be nice if it would build with ci as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants