Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add foldWhile #456

Merged
merged 6 commits into from
Nov 25, 2020
Merged

add foldWhile #456

merged 6 commits into from
Nov 25, 2020

Conversation

ocramz
Copy link
Contributor

@ocramz ocramz commented Nov 22, 2020

Addresses #453

--
-- Subject to fusion
--
-- @since TODO
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a minor version bump, changelog entry, and fill in this @since comment?


-- | Specialized version of 'mapAccumWhile' that does not provide values downstream.
--
-- Subject to fusion
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is true, since it isn't leveraging the STREAMING CPP. Can you remove it?

Copy link
Owner

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit 0bf72ae into snoyberg:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants