Always log time values in ms (close #58)

snowplow · Jun 17, 2021 · 79ffd51 · 79ffd51
1 parent 0c2e422
commit 79ffd51
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pkg/models/observer_buffer.go b/pkg/models/observer_buffer.go
@@ -131,7 +131,7 @@ func (b *ObserverBuffer) GetAvgTransformLatency() time.Duration {
 
 func (b *ObserverBuffer) String() string {
 	return fmt.Sprintf(
-		"TargetResults:%d,MsgSent:%d,MsgFailed:%d,OversizedTargetResults:%d,OversizedMsgSent:%d,OversizedMsgFailed:%d,InvalidTargetResults:%d,InvalidMsgSent:%d,InvalidMsgFailed:%d,MaxProcLatency:%s,MaxMsgLatency:%s,MaxTransformLatency:%s",
+		"TargetResults:%d,MsgSent:%d,MsgFailed:%d,OversizedTargetResults:%d,OversizedMsgSent:%d,OversizedMsgFailed:%d,InvalidTargetResults:%d,InvalidMsgSent:%d,InvalidMsgFailed:%d,MaxProcLatency:%d,MaxMsgLatency:%d,MaxTransformLatency:%d",
 		b.TargetResults,
 		b.MsgSent,
 		b.MsgFailed,
@@ -141,8 +141,8 @@ func (b *ObserverBuffer) String() string {
 		b.InvalidTargetResults,
 		b.InvalidMsgSent,
 		b.InvalidMsgFailed,
-		b.MaxProcLatency,
-		b.MaxMsgLatency,
-		b.MaxTransformLatency,
+		b.MaxProcLatency.Milliseconds(),
+		b.MaxMsgLatency.Milliseconds(),
+		b.MaxTransformLatency.Milliseconds(),
 	)
 }
diff --git a/pkg/models/observer_buffer_test.go b/pkg/models/observer_buffer_test.go
@@ -84,5 +84,5 @@ func TestObserverBuffer(t *testing.T) {
 	assert.Equal(time.Duration(1)*time.Minute, b.MinTransformLatency)
 	assert.Equal(time.Duration(2)*time.Minute, b.GetAvgTransformLatency())
 
-	assert.Equal("TargetResults:2,MsgSent:4,MsgFailed:2,OversizedTargetResults:2,OversizedMsgSent:4,OversizedMsgFailed:2,InvalidTargetResults:2,InvalidMsgSent:4,InvalidMsgFailed:2,MaxProcLatency:10m0s,MaxMsgLatency:1h10m0s,MaxTransformLatency:3m0s", b.String())
+	assert.Equal("TargetResults:2,MsgSent:4,MsgFailed:2,OversizedTargetResults:2,OversizedMsgSent:4,OversizedMsgFailed:2,InvalidTargetResults:2,InvalidMsgSent:4,InvalidMsgFailed:2,MaxProcLatency:600000,MaxMsgLatency:4200000,MaxTransformLatency:180000", b.String())
 }