Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new API endpoint for "email/unsubscribe" and fixed the response object #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added new API endpoint for "email/unsubscribe" and fixed the response object #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d263a3d
fixed response constructor - if data is null instead an empty array
Sep 23, 2016
cb73796
added new endpoint email/unsubscribe
Sep 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Snowcap/Emarsys/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,17 @@ public function getEmailResponses(array $data)
return $this->send(HttpClient::POST, 'email/getresponses', $data);
}

/**
* Count the unsubscription statistics of a specific campaign.
*
* @param array $data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there more specific type? In worse case could be @param mixed[] $data.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what $data contains, so mixed[] should fit for now.

* @return Response
*/
public function setEmailUnsubscriptionCount(array $data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not name a method getUnsubscribedUsersCount and drop docblock comment?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method removes subscribtions, so a set fits better.

{
return $this->send(HttpClient::POST, 'email/unsubscribe', $data);
}

/**
* Returns a list of email categories which can be used in email creation.
*
Expand Down
4 changes: 2 additions & 2 deletions src/Snowcap/Emarsys/Response.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ class Response
*/
function __construct(array $result = array())
{
if (!isset($result['replyCode']) || !isset($result['replyText']) || !isset($result['data'])) {
if (!isset($result['replyCode']) || !isset($result['replyText']) || !array_key_exists('data', $result)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain this modification?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why @mwille did this, but I guess this can be dropped (the effect should be the same).

throw new ClientException('Invalid result structure');
}

$this->replyCode = $result['replyCode'];
$this->replyText = $result['replyText'];
$this->data = $result['data'];
$this->data = (array) $result['data'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen here if $result['data'] is not an array?

Copy link

@kyoya-de kyoya-de Mar 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will force $this->data to be an array, it will be empty if $result['data'] is not an array (this might be better than mixed data types).

}

/**
Expand Down