-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add explore page Category and Network filters #882
base: master
Are you sure you want to change the base?
Conversation
@Sekhmet No, we don't need to support multiple category selection. |
Looks good, is it possible to sort network by name and have the possibility to search within the dropdown? Currently it's hard to find a specific network. Also if we have the counter of space for each networks I would remove network with 0 spaces. |
8575e36
to
aacad06
Compare
We don't have counter right now, we would need to fetch that info first, for now just ported it to combobox. |
On mobile, it has 2 different behaviors:
|
With DevTools it looks like when you select text right-click menu is triggered automatically. This happens on all websites, we can prevent it on initial click by delaying it to next frame, but if you click again it will be triggered anyway. Not sure if this is worth keeping, it doesn't cause real-world issues AFAIK.
This happens because we select text on focus, I added workaround so it will skip initial click, but if you click it again it will still happen. It's just what dev emulation does, if you go to other website and select some text (with keyboard shortcut) it will pop up as well. |
We would need to grow this input using JS because CSS can't do that, is that okay? |
Hum, what you can't do with CSS exactly? |
So I assume if we select longer option input should grow with it: But it's not possible with CSS alone as it's input: |
|
Ok let's keep text-center but change text to |
Summary
This PR adds ability to filter by Network and Category on explore page.
Closes: https://github.com/snapshot-labs/workflow/issues/213
@bonustrack original issue calls for multi-selection on category, but API only supports single category filter, do we want to implement it with multi-selection (would also require changes on the API).
How to test
Screenshots