feat: ensure domain uniqueness #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaituVR
requested changes
Sep 24, 2024
|
Any idea about the test @wa0x6e |
…apshot-labs/snapshot-sequencer into feat-ensure-domain-uniqueness
was unable to fix the tests, they're failing because of other tests, since the database is shared among all integrations, which are run in parallel Running the test individually work (use This test is disabled for now, so we can move on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward https://github.com/snapshot-labs/workflow/issues/142
Together with snapshot-labs/snapshot-hub#928
When saving space settings with domain, this PR will also save the domain in the
domaincolumn, and ensure that the domain is uniqueSee the hub PR for database update