fix: get network data from DB directly

[wa0x6e]

🧿 Current issues / What's wrong ?

The network query on the hub is using data from space's cache.
This create refresh lag, and dependency on the space cache object.

💊 Fixes / Solution

Use a SQL query to get networks count data from the database, and return more network properties, allowing queries like:

query Networks {
  networks {
    key
    id
    spacesCount
    name
    chainId
    network
    explorer {
      url
      apiUrl
    }
    logo
    testnet
  }
}

🚧 Changes

• Get networks count data from the database instead of space's cache
• Return more fields from networks.json. Not all fields from networks.json are returned, only the one used by the snapshot UI.

🛠️ Tests

• Query some network data from graphql => it should return same results as before, in addition to the new fields

[codecov]

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (cf26dfe) 2.41% compared to head (63099d7) 2.39%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master    #722      +/-   ##
=========================================
- Coverage    2.41%   2.39%   -0.03%     
=========================================
  Files          39      39              
  Lines        2032    2050      +18     
  Branches       37      37              
=========================================
  Hits           49      49              
- Misses       1946    1964      +18     
  Partials       37      37              

Files	Coverage Δ
src/graphql/operations/networks.ts	0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ChaituVR]

But then we will miss new networks , where no one is using them yet

[wa0x6e]

But then we will miss new networks , where no one is using them yet

Aren’t they already missing from current implementation ?

[ChaituVR]

Aren’t they already missing from current implementation ?

True lol. i thought we were using networks.json,

[ChaituVR]

Would be nice if we could add it now 😄 so then maybe we can remove networks.json dependency on snapshot UI

[ChaituVR]

Takes around 0.5 sec on prod, should be fine?

[wa0x6e]

Would be nice if we could add it now 😄 so then maybe we can remove networks.json dependency on snapshot UI

Added

[wa0x6e]

Not all fields from networks.json are returned, tell me if we need to add more.

[wa0x6e]

Pretty fast sql query, averaging 350ms execution time.

We could save the computation by caching the whole thing, and using SELECT MAX(updated) FROM spaces; as cache key

[wa0x6e]

Need fix to also include networks from inside strategies