Draft : add an async implementation of RefCell #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's allow to share data between async tasks one one thread (with local executor)
|
I think this type is already implemented as |
|
@notgull Thank's for the information. I have watch it (but not tested for now) and seems good. |
|
That would be up to the |
|
Ok @notgull, and to be associate with LocalExecutor ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft to get comment.
During my experience of implementing puffin server on only one thread with async management (https://github.com/gwen-lg/puffin/commits/async_client_connecting_local/),
I was confronted with the risk of problem with usage of await during borrow of RefCell, so I have search for an async version of RefCell, but not found, so I have tried to implement myself.
As I was in a single thread context (with LocalExecutor), use RwLock seems not the most adapted.
I have in progress test to use it here : gwen-lg/puffin@934209e
Are you interested to add a RefCell in async-lock ?
If yes, have you some remark on the work ? On how to transform the PoC into "ready to include" work ?