-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded URLs in favor of Config.routes #5557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slayer95
reviewed
Jun 27, 2019
Zarel
reviewed
Jun 27, 2019
Zarel
reviewed
Jun 28, 2019
Zarel
reviewed
Jun 28, 2019
Zarel
reviewed
Jun 28, 2019
Looks good. One day, though, we should strongly type the Config object exported from config-loader. Maybe it should extract the type exported from |
Zarel
approved these changes
Jul 1, 2019
There's a pending review request from Hoeen so I guess I'll leave this unmerged for now? |
The pending review request is automatic due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed previously, the primary motivation here is to be able to host a staging/testing environment for Pokemon Showdown's current set up. Supporting arbitrary client configurations and truly generic hosting setups is a non-goal. Starting with the server side changes here because the client changes are more involved.
After this change, running
git grep pokemonshowdown | grep -v "* Pokemon Showdown - http://pokemonshowdown.com/"
:Docs
Config
Comments
Specific replays which wouldnt exist on another server
Whitelisting
Only 'play.pokemonshowdown.com' is official, so this is still correct
PITA to change without introducing a build for these files to replay the constants. Will need to do that on the client, but seems like overkill here. Also contains a reference to psim.us, once again, not sure worth what it would take to generalize
Tests
Should probably also not be hardcoded, but translations are half baked anyway