Properly validate cosmetic forms in learnsetDomain (#10597)

smogon · Oct 2, 2024 · c55e6f6 · c55e6f6
1 parent 2e805a2
commit c55e6f6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/sim/dex-species.ts b/sim/dex-species.ts
@@ -578,7 +578,7 @@ export class DexSpecies {
 		const movePool = new Set<ID>();
 		for (const {species, learnset} of this.getFullLearnset(id)) {
 			for (const moveid in learnset) {
-				eggMovesOnly = this.eggMovesOnly(species, this.get(id));
+				if (!eggMovesOnly) eggMovesOnly = this.eggMovesOnly(species, this.get(id));
 				if (eggMovesOnly) {
 					if (learnset[moveid].some(source => source.startsWith('9E'))) {
 						movePool.add(moveid as ID);

diff --git a/sim/team-validator.ts b/sim/team-validator.ts
@@ -2779,6 +2779,9 @@ export class TeamValidator {
 		nextSpecies = baseSpecies;
 		let speciesCount = 0;
 		if (!tradebackEligible) {
+			if (!dex.species.getLearnsetData(nextSpecies.id).learnset) {
+				nextSpecies = dex.species.get(nextSpecies.changesFrom || nextSpecies.baseSpecies);
+			}
 			while (nextSpecies) {
 				for (let gen = nextSpecies.gen; gen <= dex.gen; gen++) {
 					/**

diff --git a/test/sim/team-validator/misc.js b/test/sim/team-validator/misc.js
@@ -209,6 +209,7 @@ describe('Team Validator', function () {
 
 		team = [
 			{species: 'incineroar', ability: 'blaze', moves: ['knockoff', 'partingshot'], evs: {hp: 1}},
+			{species: 'shelloseast', ability: 'stickyhold', moves: ['infestation', 'stringshot'], evs: {hp: 1}},
 		];
 		assert.legalTeam(team, 'gen8ou');
 	});