Add FFA spread move modifier support #445
Open
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK I played around with this for about an hour and refactoring this to not use 2 labels would require some serious refactors to keep the styling consistent as before (because we are just styling away elements with certain classes rather than removing them from the DOM). |
KrisXV
reviewed
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to not have doubles look rounded off in past gens, I added two labels for it, one that only displays in Gen 8 (with the btn-middle class) and one that only displays in Gens 3-7 (with the btn-right class). I am pretty sure this is not a super good way to do it (you see the extra label on page load). The proper way sounds to me like making the group of buttons into a flexbox and just applying the styling on first and last childs, but that would be a decent amount of CSS refactoring.
Screenshots:
