feat(experimentalIdentityAndAuth): add utilities for integration tests #1031
+330
−248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 13, 2023 00:41
…on tests to use integration test utilities
…on tests to use integration test utilities
20 tasks
kuhe
reviewed
Oct 13, 2023
| /** | ||
| * @internal | ||
| */ | ||
| export const expectClientCommand = async (input: any) => { |
There was a problem hiding this comment.
input should be typed since it's used in a statically typed way below
kuhe
reviewed
Oct 13, 2023
| const { | ||
| // Constructors | ||
| clientConstructor, | ||
| commandConstructor, |
There was a problem hiding this comment.
type __<Client, Config, Command> = {
clientConstructor: { new(config: Config): Client },
commandConstructor: { new(): Command },
defaultClientConfig?: Partial<Config>,
clientConfig?: Partial<Config>,
requestMatchers?: HttpRequestMatcher,
contextExpectFn?: (c: HandlerExecutionContext): any,
clientRejects?: string
}
hpmellema
pushed a commit
to hpmellema/smithy-typescript
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A.
Description of changes:
Add utilities for integration tests:
@httpApiKeyAuthintegration tests to use integration test utilities@httpBearerAuthintegration tests to use integration test utilitiesIf one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.