Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deconvolution GUI Modularity #2429

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Commits on May 21, 2024

  1. Configuration menu
    Copy the full SHA
    8be2574 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a00af8a View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. merged in master

    nbollis committed May 30, 2024
    Configuration menu
    Copy the full SHA
    22c60ba View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. merged in master bbbyy

    nbollis committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f4695bb View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Configuration menu
    Copy the full SHA
    d4f8b9d View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. merged in master

    nbollis committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    1f0dc48 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. idkman

    nbollis committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    5c0268b View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. merged in master

    nbollis committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b7e6a0f View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    6446d89 View commit details
    Browse the repository at this point in the history
  2. Spectral Library from Command Line (smith-chem-wisc#2386)

    * Updated to MzLib 1.0.548 and fixed custom ions in search tasks
    
    * reverted calibration task change
    
    * merged in master bbbyy
    
    * Enabled Library Loading from command line
    nbollis committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    322235d View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. merged in master

    nbollis committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    8b48c95 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ef973f View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Configuration menu
    Copy the full SHA
    0abcd9b View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. merged in master

    nbollis committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f9030f9 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. merged in master

    nbollis committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    046067e View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Configuration menu
    Copy the full SHA
    c38f081 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Configuration menu
    Copy the full SHA
    0c04007 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Merge remote-tracking branch 'upstream/master'

    Nic Bollis committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d66bf7b View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Build ClassicDeconv Params View Model

    Nic Bollis committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    57c4e69 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0cef4fc View commit details
    Browse the repository at this point in the history
  3. Refactor deconvolution param management with ViewModel

    Streamlined deconvolution parameter management by introducing `DeconHostViewModel` and custom control `HostDeconParamControl`. Updated `CommonParameters.cs` to change default `ProductDeconvolutionParameters` in negative mode from `-10` to `-20`. Modified `SearchTaskWindow.xaml` and `SearchTaskWindow.xaml.cs` to use the new view model, improving separation of concerns and maintainability. Updated `SaveButton_Click` and other relevant methods to retrieve parameters via the view model.
    Nic Bollis committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    2a73a02 View commit details
    Browse the repository at this point in the history
  4. Completed the first phase of the new structure. Parameters can now be…

    … set from the GUI with the new code structure
    Nic Bollis committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    1735439 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. Refactor UI and add comprehensive unit tests

    Refactored several XAML files to improve UI structure and readability:
    - Removed unnecessary `GroupBox` in `SearchTaskWindow.xaml` and added a new one for "Peak Trimming".
    - Adjusted layout in `ClassicDeconParamsControl.xaml` and `HostDeconParamControl.xaml`.
    
    Enhanced ViewModel logic:
    - Updated `DeconHostViewModel.cs` and `DeconParamsViewModel.cs` to include additional properties and validation logic.
    - Added `[ExcludeFromCodeCoverage]` attribute to `IsoDecDeconParamsViewModel.cs`.
    
    Expanded unit tests:
    - Removed obsolete `GuiFunctionsTest.cs`.
    - Added new test classes for `ClassicDeconParamsViewModel`, `DeconParamsViewModel`, `DeconHostViewModel`, and `MzLibExtensions`.
    - Included tests for property changes, validation logic, and conversion methods.
    Nic Bollis committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    4eff135 View commit details
    Browse the repository at this point in the history
  2. Expanded test coverage and cleaned up code

    Nic Bollis committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    d32800c View commit details
    Browse the repository at this point in the history
  3. added control to GPTMD window

    Nic Bollis committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    fc8304d View commit details
    Browse the repository at this point in the history
  4. Expanded test coverage

    Nic Bollis committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    f8d318a View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Configuration menu
    Copy the full SHA
    7aae734 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Configuration menu
    Copy the full SHA
    11227eb View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Configuration menu
    Copy the full SHA
    c222ba7 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Configuration menu
    Copy the full SHA
    9a3b9db View commit details
    Browse the repository at this point in the history