-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spectral recovery update #2273
Open
Alexander-Sol
wants to merge
54
commits into
smith-chem-wisc:master
Choose a base branch
from
Alexander-Sol:SpectralRecoveryUpdate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Spectral recovery update #2273
Alexander-Sol
wants to merge
54
commits into
smith-chem-wisc:master
from
Alexander-Sol:SpectralRecoveryUpdate
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2273 +/- ##
==========================================
- Coverage 92.02% 91.90% -0.12%
==========================================
Files 135 134 -1
Lines 20602 20343 -259
Branches 2828 2829 +1
==========================================
- Hits 18958 18696 -262
Misses 1161 1161
- Partials 483 486 +3
|
Added Readers to product.wxs
…-Sol/MetaMorpheus into SpectralRecoveryUpdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, spectral recovery was dependent on deconvolution. The updated version uses isolation windows, not deconvoluted precursors, to locate Ms2 spectra associated with MBR-transferred identifications.
This change results in increased performance, as measured by the spectral contrast angle between the recovered and donor spectrum. Tests were edited to account for this.