Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather App Added #99

Merged
merged 13 commits into from
Aug 6, 2024
Merged

Conversation

DevanshPaliwal
Copy link
Contributor

@DevanshPaliwal DevanshPaliwal commented Aug 2, 2024

Related Issue

#95

Description

Added a weather app with realtime weather data and upto 7 days forecast

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

github-actions bot commented Aug 2, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

guardrails bot commented Aug 2, 2024

⚠️ We detected 11 security issues in this pull request:

Hard-Coded Secrets (1)
Severity Details Docs
Medium Title: Secret Keyword
https://github.com/smilewithkhushi/BasicNative/blob/9fbd3588a320c92cf1a52a2f4ea4f0bea0b7f0a7/Weather App/api/weather.js#L3
📚

More info on how to fix Hard-Coded Secrets in General.


Vulnerable Libraries (10)
Severity Details
Critical [pkg:npm/[email protected]](https://github.com/smilewithkhushi/BasicNative/blob/9fbd3588a320c92cf1a52a2f4ea4f0bea0b7f0a7/Weather App/package.json#L30) upgrade to: > 4.0.0
High [pkg:npm/[email protected]](https://github.com/smilewithkhushi/BasicNative/blob/9fbd3588a320c92cf1a52a2f4ea4f0bea0b7f0a7/Weather App/package.json#L31) upgrade to: > 4.2.0
High [pkg:npm/[email protected]](https://github.com/smilewithkhushi/BasicNative/blob/9fbd3588a320c92cf1a52a2f4ea4f0bea0b7f0a7/Weather App/package.json#L21) upgrade to: > 2.0.11
High [pkg:npm/[email protected]](https://github.com/smilewithkhushi/BasicNative/blob/9fbd3588a320c92cf1a52a2f4ea4f0bea0b7f0a7/Weather App/package.json#L48) upgrade to: > 3.3.2
High [pkg:npm/@react-native/[email protected]](https://github.com/smilewithkhushi/BasicNative/blob/9fbd3588a320c92cf1a52a2f4ea4f0bea0b7f0a7/Weather App/package.json#L38) upgrade to: > 0.74.81
High [pkg:npm/[email protected]](https://github.com/smilewithkhushi/BasicNative/blob/9fbd3588a320c92cf1a52a2f4ea4f0bea0b7f0a7/Weather App/package.json#L23) upgrade to: > 0.74.0
High [pkg:npm/@react-native/[email protected]](https://github.com/smilewithkhushi/BasicNative/blob/9fbd3588a320c92cf1a52a2f4ea4f0bea0b7f0a7/Weather App/package.json#L39) upgrade to: > 0.74.81
High [pkg:npm/@react-native/[email protected]](https://github.com/smilewithkhushi/BasicNative/blob/9fbd3588a320c92cf1a52a2f4ea4f0bea0b7f0a7/Weather App/package.json#L37) upgrade to: > 0.74.81
High [pkg:npm/[email protected]](https://github.com/smilewithkhushi/BasicNative/blob/9fbd3588a320c92cf1a52a2f4ea4f0bea0b7f0a7/Weather App/package.json) (t) upgrade to: > 29.7.0
High [pkg:npm/[email protected]](https://github.com/smilewithkhushi/BasicNative/blob/9fbd3588a320c92cf1a52a2f4ea4f0bea0b7f0a7/Weather App/package.json) (t) upgrade to: > 29.7.0

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@DevanshPaliwal
Copy link
Contributor Author

@smilewithkhushi please accept this PR under Gssoc 24, only a few days remaining

@smilewithkhushi smilewithkhushi merged commit 9848b46 into smilewithkhushi:master Aug 6, 2024
@smilewithkhushi smilewithkhushi added gssoc Issue for GSSoC'24 level2 Level 2 Issue for GSSoC'24 labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Issue for GSSoC'24 level2 Level 2 Issue for GSSoC'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants