Support non-action releases with release-action-node #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anttiharju
changed the title
Useful for non-action releases.
Useful for determining whether to send slack notifications afterwards.
|
Need something more specific, it's close, but adding ifs to accomodate just makes this a mess. Good template to build off of nonetheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To be able to use this in a service.
Concern
The action name no longer matches what it does if its use is expanded outside action releases. But I don't think releasing a separate action (
release-node?) is desirable either as the resulting action would be very similar to this one, creating an unnecessary maintenance burden. Can always be split later.