Feature/mobile projection #2080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add projection app to audio app list as it can stream audio This is done to enable HMI leve switching to LIMITED level.
1 task
There was added PROJECTION HMI type to the notifications_per_minute_by_priority structure. Also this structure was updated in the policy types to make everything work correctly.
BSolonenko
force-pushed
the
feature/mobile_projection
branch
from
af14f5c to
6927d26
Compare
This was referenced Mar 23, 2018
BSolonenko
force-pushed
the
feature/mobile_projection
branch
from
6927d26 to
12866af
Compare
Update preloaded PT with PROJECTION HMI type
BSolonenko
force-pushed
the
feature/mobile_projection
branch
from
12866af to
21b7b70
Compare
yang1070
reviewed
May 4, 2018
| @@ -228,7 +228,8 @@ void ApplicationImpl::set_voice_communication_supported( | |||
| } | |||
|
|
|||
| bool ApplicationImpl::IsAudioApplication() const { | |||
| return is_media_ || is_voice_communication_application_ || is_navi_; | |||
| return is_media_ || is_voice_communication_application_ || is_navi_ || | |||
| mobile_projection_enabled_; | |||
There was a problem hiding this comment.
why it is or with mobile_projection_enabled_?
mobile_projection app can be media or non-media. For non-media mobile projection app, it is wrong.
There was a problem hiding this comment.
|
Can one of the admins verify this patch? |
|
Duplicate changes to #2155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
HMI : smartdevicelink/sdl_hmi#53
ATF Tests: smartdevicelink/sdl_atf_test_scripts#1855
Summary
This PR contains changes related to Mobile projections
Code : #2080
HMI : smartdevicelink/sdl_hmi#53
SDL documentation : Not SAD changed required
ATF Tests: smartdevicelink/sdl_atf_test_scripts#1855
HMI Integration guilelines : smartdevicelink/sdl_hmi_integration_guidelines#92
SDL requirenments : smartdevicelink/sdl_requirements#56
CLA