-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize LLO transmitter queue deletes using batching #16166
base: develop
Are you sure you want to change the base?
Conversation
samsondav
commented
Jan 31, 2025
•
edited
Loading
edited
I see you updated files related to
|
32eba2d
to
522de6a
Compare
2a8ecb0
to
0f4bb4e
Compare
- This reduces required number of DB connections and should reduce overall DB transaction load - The server doesn't need to be aware of DB deletion at all, the persistence manager now handles all of it
0f4bb4e
to
80ca5cf
Compare
Quality Gate passedIssues Measures |
AER Report: CI Coreaer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Core Tests (go_core_tests) , GolangCI Lint (.) , Core Tests (go_core_tests_integration) , test-scripts , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan 1. Linting error: defer inside loopsJob ID: Golang Lint (.) Source of Error:core/services/llo/mercurytransmitter/persistence_manager.go:128:4: defer: prefer not to defer inside loops (revive)
defer cancel()
^ Why: The Suggested fix: Move the 2. Test failure: Condition never satisfiedJob ID: Run tests Source of Error:testutils.go:341:
Error Trace: /home/runner/work/chainlink/chainlink/core/internal/testutils/testutils.go:341
/home/runner/work/chainlink/chainlink/core/internal/testutils/testutils.go:365
/home/runner/work/chainlink/chainlink/core/services/llo/mercurytransmitter/persistence_manager_test.go:70
Error: Condition never satisfied
Test: TestPersistenceManagerAsyncDelete
logger.go:146: 2025-01-31T16:54:52.252Z ERROR LLOPersistenceManager mercurytransmitter/persistence_manager.go:194 Failed to prune transmit requests table {"version": "unset@unset", "serverURL": "wss://example.com/mercury", "err": "llo orm: failed to prune transmissions: context canceled"}
github.com/smartcontractkit/chainlink/v2/core/services/llo/mercurytransmitter.(*persistenceManager).runPruneLoop.func1
/home/runner/work/chainlink/chainlink/core/services/llo/mercurytransmitter/persistence_manager.go:194
github.com/smartcontractkit/chainlink/v2/core/services/llo/mercurytransmitter.(*persistenceManager).runPruneLoop
/home/runner/work/chainlink/chainlink/core/services/llo/mercurytransmitter/persistence_manager.go:198
FAIL Why: The test Suggested fix: Ensure that the context is not prematurely canceled or adjust the test to handle the context cancellation appropriately. Consider increasing the timeout or refactoring the code to ensure the prune operation completes within the expected time frame. |