Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump framework/chains; use package heads #16162

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

bump framework/chains; use package heads #16162

wants to merge 1 commit into from
+953 −959

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Jan 30, 2025

@jmank88 jmank88 mentioned this pull request Jan 30, 2025
Draft
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@github-actions GitHub Actions
Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , GolangCI Lint (core/scripts) , GolangCI Lint (.) , test-scripts , GolangCI Lint (integration-tests/load) , GolangCI Lint (integration-tests) , GolangCI Lint (deployment) , lint , SonarQube Scan

1. Undefined function htMocks.NewHeadTracker in tests: [Golang Lint, Run tests]

Source of Error: 
Golang Lint (.)	2025-01-30T23:41:45.0713323Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:232:25: undefined: htMocks.NewHeadTracker
Golang Lint (.)	2025-01-30T23:41:45.0715125Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:339:25: undefined: htMocks.NewHeadTracker
Golang Lint (.)	2025-01-30T23:41:45.0716205Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:581:26: undefined: htMocks.NewHeadTracker
Golang Lint (.)	2025-01-30T23:41:45.0717331Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:590:26: undefined: htMocks.NewHeadTracker
Golang Lint (.)	2025-01-30T23:41:45.0718629Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:692:26: undefined: htMocks.NewHeadTracker
Golang Lint (.)	2025-01-30T23:41:45.0719742Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:713:26: undefined: htMocks.NewHeadTracker
Golang Lint (.)	2025-01-30T23:41:45.0720835Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:733:26: undefined: htMocks.NewHeadTracker
Golang Lint (.)	2025-01-30T23:41:45.0721999Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:751:26: undefined: htMocks.NewHeadTracker (typecheck)
Run tests	2025-01-30T23:47:31.9327095Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:232:25: undefined: htMocks.NewHeadTracker
Run tests	2025-01-30T23:47:31.9465138Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:339:25: undefined: htMocks.NewHeadTracker
Run tests	2025-01-30T23:47:31.9467736Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:581:26: undefined: htMocks.NewHeadTracker
Run tests	2025-01-30T23:47:31.9470069Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:590:26: undefined: htMocks.NewHeadTracker
Run tests	2025-01-30T23:47:31.9472321Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:692:26: undefined: htMocks.NewHeadTracker
Run tests	2025-01-30T23:47:31.9474967Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:713:26: undefined: htMocks.NewHeadTracker
Run tests	2025-01-30T23:47:31.9477286Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:733:26: undefined: htMocks.NewHeadTracker
Run tests	2025-01-30T23:47:31.9479569Z ##[error]core/chains/evm/logpoller/log_poller_internal_test.go:751:26: undefined: htMocks.NewHeadTracker

Why: The error occurs because the function htMocks.NewHeadTracker is not defined or imported in the test files. This results in the linter and tests failing due to undefined references.

Suggested fix: Ensure that htMocks.NewHeadTracker is correctly defined and imported in the test files. Verify that the htMocks package is correctly referenced and that the function exists within it.

2. Undefined function htmocks.NewHeadBroadcaster in tests: [Golang Lint, Run tests]

Source of Error: 
Golang Lint (.)	2025-01-30T23:41:45.0739976Z ##[error]core/services/ocr/contract_tracker_test.go:51:19: undefined: htmocks.HeadBroadcaster
Golang Lint (.)	2025-01-30T23:41:45.0741008Z ##[error]core/services/ocr/contract_tracker_test.go:79:19: undefined: htmocks.NewHeadBroadcaster (typecheck)
Run tests	2025-01-30T23:48:30.4905518Z ##[error]core/services/ocr/contract_tracker_test.go:51:19: undefined: htmocks.HeadBroadcaster
Run tests	2025-01-30T23:48:30.4910437Z ##[error]core/services/ocr/contract_tracker_test.go:79:19: undefined: htmocks.NewHeadBroadcaster

Why: The error occurs because the function htmocks.NewHeadBroadcaster is not defined or imported in the test files. This results in the linter and tests failing due to undefined references.

Suggested fix: Ensure that htmocks.NewHeadBroadcaster is correctly defined and imported in the test files. Verify that the htmocks package is correctly referenced and that the function exists within it.

3. Undefined function htmocks.NewHeadTracker in tests: [Golang Lint, Run tests]

Source of Error: 
Golang Lint (.)	2025-01-30T23:41:45.0744816Z ##[error]core/services/ocr2/plugins/ocr2keeper/evmregistry/v20/registry_test.go:49:19: undefined: htmocks.NewHeadTracker (typecheck)
Run tests	2025-01-30T23:48:52.9141037Z ##[error]core/services/ocr2/plugins/ocr2keeper/evmregistry/v20/registry_test.go:49:19: undefined: htmocks.NewHeadTracker

Why: The error occurs because the function htmocks.NewHeadTracker is not defined or imported in the test files. This results in the linter and tests failing due to undefined references.

Suggested fix: Ensure that htmocks.NewHeadTracker is correctly defined and imported in the test files. Verify that the htmocks package is correctly referenced and that the function exists within it.

4. Undefined function htmocks.NewHeadBroadcaster in tests: [Golang Lint, Run tests]

Source of Error: 
Golang Lint (.)	2025-01-30T23:41:45.0748900Z ##[error]core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/block_subscriber_test.go:278:16: undefined: htmocks.NewHeadBroadcaster (typecheck)
Run tests	2025-01-30T23:48:52.9450077Z ##[error]core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/block_subscriber_test.go:278:16: undefined: htmocks.NewHeadBroadcaster

Why: The error occurs because the function htmocks.NewHeadBroadcaster is not defined or imported in the test files. This results in the linter and tests failing due to undefined references.

Suggested fix: Ensure that htmocks.NewHeadBroadcaster is correctly defined and imported in the test files. Verify that the htmocks package is correctly referenced and that the function exists within it.

5. Undefined function htmocks.HeadBroadcaster in tests: [Golang Lint, Run tests]

Source of Error: 
Golang Lint (.)	2025-01-30T23:41:45.0751741Z ##[error]core/services/relay/evm/request_round_tracker_test.go:49:31: undefined: htmocks.HeadBroadcaster
Golang Lint (.)	2025-01-30T23:41:45.0752730Z ##[error]core/services/relay/evm/request_round_tracker_test.go:77:19: undefined: htmocks.NewHeadBroadcaster
Run tests	2025-01-30T23:49:25.8015123Z ##[error]core/services/relay/evm/request_round_tracker_test.go:49:31: undefined: htmocks.HeadBroadcaster
Run tests	2025-01-30T23:49:25.8019522Z ##[error]core/services/relay/evm/request_round_tracker_test.go:77:19: undefined: htmocks.NewHeadBroadcaster

Why: The error occurs because the function htmocks.HeadBroadcaster is not defined or imported in the test files. This results in the linter and tests failing due to undefined references.

Suggested fix: Ensure that htmocks.HeadBroadcaster is correctly defined and imported in the test files. Verify that the htmocks package is correctly referenced and that the function exists within it.

6. Undefined function htMocks.NewHeadTracker in tests: [Golang Lint, Run tests]

Source of Error: 
Golang Lint (.)	2025-01-30T23:41:45.0753708Z ##[error]core/services/relay/evm/chain_components_test.go:222:16: undefined: htMocks.NewHeadTracker
Run tests	2025-01-30T23:49:25.8021315Z ##[error]core/services/relay/evm/chain_components_test.go:222:16: undefined: htMocks.NewHeadTracker

Why: The error occurs because the function htMocks.NewHeadTracker is not defined or imported in the test files. This results in the linter and tests failing due to undefined references.

Suggested fix: Ensure that htMocks.NewHeadTracker is correctly defined and imported in the test files. Verify that the htMocks package is correctly referenced and that the function exists within it.

7. Undefined function mocks.NewHeadTracker in tests: [Golang Lint, Run tests]

Source of Error: 
Golang Lint (.)	2025-01-30T23:41:45.0754750Z ##[error]core/services/relay/evm/write_target_test.go:120:14: undefined: mocks.NewHeadTracker (typecheck)
Run tests	2025-01-30T23:49:25.8022763Z ##[error]core/services/relay/evm/write_target_test.go:120:14: undefined: mocks.NewHeadTracker

Why: The error occurs because the function mocks.NewHeadTracker is not defined or imported in the test files. This results in the linter and tests failing due to undefined references.

Suggested fix: Ensure that mocks.NewHeadTracker is correctly defined and imported in the test files. Verify that the mocks package is correctly referenced and that the function exists within it.

8. Undefined function htmocks.NewHeadTracker in tests: [Golang Lint, Run tests]

Source of Error: 
Golang Lint (.)	2025-01-30T23:41:45.0757743Z ##[error]core/services/relay/evm/mercury/v1/data_source_test.go:119:15: undefined: htmocks.NewHeadTracker
Golang Lint (.)	2025-01-30T23:41:45.0758979Z ##[error]core/services/relay/evm/mercury/v1/data_source_test.go:210:20: undefined: htmocks.NewHeadTracker
Golang Lint (.)	2025-01-30T23:41:45.0760006Z ##[error]core/services/relay/evm/mercury/v1/data_source_test.go:321:19: undefined: htmocks.NewHeadTracker
Golang Lint (.)	2025-01-30T23:41:45.0761036Z ##[error]core/services/relay/evm/mercury/v1/data_source_test.go:345:19: undefined: htmocks.NewHeadTracker
Golang Lint (.)	2025-01-30T23:41:45.0762085Z ##[error]core/services/relay/evm/mercury/v1/data_source_test.go:368:19: undefined: htmocks.NewHeadTracker
Golang Lint (.)	2025-01-30T23:41:45.0763087Z ##[error]core/services/relay/evm/mercury/v1/data_source_test.go:413:26: undefined: htmocks.NewHeadTracker
Golang Lint (.)	2025-01-30T23:41:45.0764144Z ##[error]core/services/relay/evm/mercury/v1/data_source_test.go:430:26: undefined: htmocks.NewHeadTracker (typecheck)
Run tests	2025-01-30T23:51:29.7119765Z ##[error]core/services/relay/evm/mercury/v1/data_source_test.go:119:15: undefined: htmocks.NewHeadTracker
Run tests	2025-01-30T23:51:29.7121878Z ##[error]core/services/relay/evm/mercury/v1/data_source_test.go:210:20: undefined: htmocks.NewHeadTracker
Run tests	2025-01-30T23:51:29.7123658Z ##[error]core/services/relay/evm/mercury/v1/data_source_test.go:321:19: undefined: htmocks.NewHeadTracker
Run tests	2025-01-30T23:51:29.7125136Z ##[error]core/services/relay/evm/mercury/v1/data_source_test.go:345:19: undefined: htmocks.NewHeadTracker
Run tests	2025-01-30T23:51:29.7126615Z ##[error]core/services/relay/evm/mercury/v1/data_source_test.go:368:19: undefined: htmocks.NewHeadTracker
Run tests	2025-01-30T23:51:29.7128107Z ##[error]core/services/relay/evm/mercury/v1/data_source_test.go:413:26: undefined: htmocks.NewHeadTracker
Run tests	2025-01-30T23:51:29.7131383Z ##[error]core/services/relay/evm/mercury/v1/data_source_test.go:430:26: undefined: htmocks.NewHeadTracker

Why: The error occurs because the function htmocks.NewHeadTracker is not defined or imported in the test files. This results in the linter and tests failing due to undefined references.

Suggested fix: Ensure that htmocks.NewHeadTracker is correctly defined and imported in the test files. Verify that the htmocks package is correctly referenced and that the function exists within it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-raykov pavel-raykov Awaiting requested review from pavel-raykov pavel-raykov will be requested when the pull request is marked ready for review pavel-raykov is a code owner

@DylanTinianov DylanTinianov Awaiting requested review from DylanTinianov DylanTinianov will be requested when the pull request is marked ready for review DylanTinianov is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmank88