Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to deploy CCIP Solana to staging #16160

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jlaveracll
Copy link
Contributor

Requires

Supports

@@ -40,7 +40,7 @@ type EVMChain struct {
Users []*bind.TransactOpts
}

type SolanaChain struct {
type SolanaChainConfig struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to keep this named SolanaChain? I understand it collides with other SolanaChain names but we also have EVMChain in this file and would probably want to be consistent with those.

Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Scheduled Run Frequency , Detect Changes , Clean Go Tidy & Generate , GolangCI Lint (deployment) , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , test-scripts , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. Undefined variable solCommomUtil in environment/memory/environment.go:[Golang Lint (deployment)]

Source of Error:
##[error]deployment/ccip/changeset/testhelpers/test_environment.go:31:2: could not import github.com/smartcontractkit/chainlink/deployment/environment/memory (-: # github.com/smartcontractkit/chainlink/deployment/environment/memory
##[error]environment/memory/environment.go:96:61: undefined: solCommomUtil
##[error]environment/memory/environment.go:97:15: undefined: solCommomUtil) (typecheck)

Why: The variable solCommomUtil is referenced in the environment/memory/environment.go file but is not defined anywhere in the code, causing the import and typecheck to fail.

Suggested fix: Define the solCommomUtil variable in the appropriate scope or import it from the correct package if it exists elsewhere.

2. Unused variables and imports in various test files:[Golang Lint (deployment)]

Source of Error:
##[error]deployment/ccip/changeset/cs_accept_admin_role_test.go:19:19: declared and not used: tokens (typecheck)
##[error]deployment/ccip/changeset/cs_active_candidate_test.go:139:3: declared and not used: block (typecheck)
##[error]deployment/ccip/changeset/cs_active_candidate_test.go:193:2: declared and not used: tokenConfig (typecheck)
##[error]deployment/ccip/changeset/cs_ccip_home_test.go:35:2: declared and not used: envNodes (typecheck)
##[error]deployment/ccip/changeset/cs_ccip_home_test.go:248:4: declared and not used: tokenConfig (typecheck)
##[error]deployment/ccip/changeset/cs_ccip_home_test.go:361:4: declared and not used: tokenConfig (typecheck)
##[error]deployment/ccip/changeset/cs_configure_token_pools_test.go:145:19: declared and not used: tokens (typecheck)
##[error]deployment/ccip/changeset/cs_configure_token_pools_test.go:405:5: declared and not used: lockReleaseA (typecheck)
##[error]deployment/ccip/changeset/cs_configure_token_pools_test.go:406:5: declared and not used: burnMintA (typecheck)
##[error]deployment/ccip/changeset/cs_configure_token_pools_test.go:408:5: declared and not used: lockReleaseB (typecheck)
##[error]deployment/ccip/changeset/cs_configure_token_pools_test.go:409:5: declared and not used: burnMintB (typecheck)
##[error]deployment/ccip/changeset/cs_configure_token_pools_test.go:547:6: declared and not used: aType (typecheck)
##[error]deployment/ccip/changeset/cs_configure_token_pools_test.go:551:6: declared and not used: bType (typecheck)
##[error]deployment/ccip/changeset/cs_configure_token_pools_test.go:314:2: declared and not used: acceptLiquidity (typecheck)
##[error]deployment/ccip/changeset/cs_deploy_token_pools_test.go:283:19: declared and not used: tokens (typecheck)
##[error]deployment/ccip/changeset/cs_accept_admin_role_test.go:9:2: "github.com/smartcontractkit/chainlink/deployment" imported and not used (typecheck)
##[error]deployment/ccip/changeset/cs_active_candidate_test.go:4:2: "math/big" imported and not used (typecheck)
##[error]deployment/ccip/changeset/cs_active_candidate_test.go:23:2: "github.com/smartcontractkit/chainlink/v2/core/logger" imported and not used (typecheck)
##[error]deployment/ccip/changeset/cs_ccip_home_test.go:4:2: "math/big" imported and not used (typecheck)
##[error]deployment/ccip/changeset/cs_ccip_home_test.go:13:2: "github.com/smartcontractkit/chainlink-ccip/chainconfig" imported and not used (typecheck)
##[error]deployment/ccip/changeset/cs_ccip_home_test.go:14:2: "github.com/smartcontractkit/chainlink-ccip/pkg/types/ccipocr3" imported as cciptypes and not used (typecheck)
##[error]deployment/ccip/changeset/cs_ccip_home_test.go:19:2: "github.com/smartcontractkit/chainlink/deployment/ccip/changeset/globals" imported and not used (typecheck)
##[error]deployment/ccip/changeset/cs_ccip_home_test.go:23:2: "github.com/smartcontractkit/chainlink/v2/core/logger" imported and not used (typecheck)
##[error]deployment/ccip/changeset/cs_propose_admin_role_test.go:9:2: "github.com/smartcontractkit/chainlink/deployment" imported and not used (typecheck)
##[error]deployment/ccip/changeset/cs_transfer_admin_role_test.go:9:2: "github.com/smartcontractkit/chainlink/deployment" imported and not used (typecheck)
##[error]deployment/common/changeset/set_config_mcms_test.go:36:2: declared and not used: config (typecheck)
##[error]deployment/common/changeset/example/link_transfer_test.go:35:2: declared and not used: config (typecheck)
##[error]deployment/keystone/changeset/accept_ownership_test.go:54:2: declared and not used: timelock (typecheck)
##[error]deployment/keystone/changeset/append_node_capabilities_test.go:91:3: declared and not used: contracts (typecheck)
##[error]deployment/keystone/changeset/deploy_ocr3_test.go:276:3: declared and not used: contracts (typecheck)
##[error]deployment/keystone/changeset/update_don_test.go:125:3: declared and not used: contracts (typecheck)
##[error]deployment/keystone/changeset/internal/deploy_test.go:24:3: declared and not used: registry (typecheck)
##[error]deployment/keystone/changeset/internal/deploy_test.go:380:4: declared and not used: regContract (typecheck)
##[error]deployment/keystone/changeset/internal/deploy_test.go:285:3: declared and not used: registry (typecheck)

Why: These errors are caused by variables and imports that are declared but not used in the code, which is flagged by the linter.

Suggested fix: Remove the unused variables and imports to clean up the code and resolve the linter errors.

3. Build failures due to undefined solCommomUtil in tests:[Core Tests (go_core_ccip_deployment_tests)]

Source of Error:
##[error]environment/memory/environment.go:96:61: undefined: solCommomUtil
##[error]environment/memory/environment.go:97:15: undefined: solCommomUtil

Why: The build failures in the tests are due to the same undefined solCommomUtil variable in the environment/memory/environment.go file.

Suggested fix: Define the solCommomUtil variable in the appropriate scope or import it from the correct package if it exists elsewhere. This will resolve the build failures in the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants