Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CCIP Contract Reader Querying #14935

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Oct 24, 2024

related chainlink-ccip PR smartcontractkit/chainlink-ccip#267

Also relates to
CCIP-3866
and
CCIP-3865

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Copy link
Contributor

github-actions bot commented Oct 24, 2024

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , lint , Core Tests (go_core_tests) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , SonarQube Scan , Flakey Test Detection

1. Transaction receipt not found: go_core_ccip_deployment_tests

Source of Error:
2024-10-24T12:07:04.653Z	ERROR	EVM.1337.Txm.Confirmer.BatchFetchReceipts	txmgr/confirmer.go:678	FetchReceipt failed	{"version": "2.17.0@1dbe7b7", "blockNum": 528, "txID": 1607, "sequence": "122", "checker": "{\"CheckerType\": \"simulate\"}", "feeLimit": 2000000, "txHash": "0x748f9e7598eca174d5f3a984880c17a2772a43d9c2abc7ae4c8d8c104b962789", "txAttemptID": 1553, "txID": 1607, "err": "not found", "sequence": "122"}

Why: The transaction receipt for the transaction with hash 0x748f9e7598eca174d5f3a984880c17a2772a43d9c2abc7ae4c8d8c104b962789 could not be found, indicating that the transaction might not have been mined or there was an issue with the transaction propagation.

Suggested fix: Ensure the transaction is properly broadcasted and check the network status to confirm if the transaction is being mined. Retry fetching the receipt after some time or investigate potential issues with the transaction submission.

2. Error handling tx queue: go_core_ccip_deployment_tests

Source of Error:
2024-10-24T12:07:18.904Z	ERROR	EVM.1337.Txm.Broadcaster	txmgr/broadcaster.go:323	Error occurred while handling tx queue in ProcessUnstartedTxs	{"version": "2.17.0@1dbe7b7", "err": "processUnstartedTxs failed on handleAnyInProgressTx: handleAnyInProgressTx failed: getInProgressEthTx failed: context canceled"}

Why: The error occurred because the context was canceled while trying to handle in-progress transactions, possibly due to a shutdown or interruption in the process.

Suggested fix: Ensure that the context is not prematurely canceled and that the transaction handling process is allowed to complete. Investigate any potential interruptions or shutdown signals that might be affecting the process.

3. Error processing head: go_core_ccip_deployment_tests

Source of Error:
2024-10-24T12:07:18.904Z	ERROR	EVM.1337.Txm.Confirmer	txmgr/confirmer.go:278	Error processing head	{"version": "2.17.0@1dbe7b7", "err": "RebroadcastWhereNecessary failed: FindTxsRequiringRebroadcast failed: FindEthTxsRequiringResubmissionDueToInsufficientEth failed to load evm.txes: context canceled"}

Why: The error occurred because the context was canceled while trying to rebroadcast transactions that require resubmission due to insufficient ETH.

Suggested fix: Ensure that the context remains active during the rebroadcast process and investigate any potential issues causing the context to be canceled. Ensure sufficient ETH is available for transaction resubmission.

4. Test condition never satisfied: go_core_tests

Source of Error:
2024-10-24T12:07:48.8288441Z ##[group] �[0;31m❌ TestChainComponents/Filtering_can_be_done_on_data_words_using_value_comparator_on_a_nested_field (30.00s) �[0m
2024-10-24T12:07:48.8289190Z �[0;31m 	Error Trace:	/home/runner/work/chainlink/chainlink/core/services/relay/evm/evmtesting/run_tests.go:188 �[0m
2024-10-24T12:07:48.8289504Z �[0;31m 	Error: 	Condition never satisfied �[0m
2024-10-24T12:07:48.8290158Z �[0;31m 	Test: 	TestChainComponents/Filtering_can_be_done_on_data_words_using_value_comparator_on_a_nested_field �[0m

Why: The test condition for filtering data words using a value comparator on a nested field was never satisfied, indicating a potential issue with the test logic or the data being tested.

Suggested fix: Review the test logic and ensure that the data being tested meets the expected conditions. Verify that the value comparator is correctly implemented and that the nested field is accessible and contains the expected values.

5. Test condition never satisfied: go_core_tests

Source of Error:
2024-10-24T12:07:48.8291423Z ##[group] �[0;31m❌ TestChainComponents/Filtering_can_be_done_on_data_words_using_value_comparator_on_field_that_follows_a_dynamic_field (30.00s) �[0m
2024-10-24T12:07:48.8292175Z �[0;31m 	Error Trace:	/home/runner/work/chainlink/chainlink/core/services/relay/evm/evmtesting/run_tests.go:208 �[0m
2024-10-24T12:07:48.8292468Z �[0;31m 	Error: 	Condition never satisfied �[0m
2024-10-24T12:07:48.8293330Z �[0;31m 	Test: 	TestChainComponents/Filtering_can_be_done_on_data_words_using_value_comparator_on_field_that_follows_a_dynamic_field �[0m

Why: The test condition for filtering data words using a value comparator on a field that follows a dynamic field was never satisfied, indicating a potential issue with the test logic or the data being tested.

Suggested fix: Review the test logic and ensure that the data being tested meets the expected conditions. Verify that the value comparator is correctly implemented and that the field following the dynamic field is accessible and contains the expected values.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@ilija42 ilija42 force-pushed the CCIP-2896-improve-ccip-contract-reader-querying branch from e895eb2 to 0f768d5 Compare October 24, 2024 11:52
@ilija42 ilija42 changed the title Fix Contract Reader data word index calculation Improve CCIP Contract Reader Querying Oct 24, 2024
@ilija42 ilija42 marked this pull request as ready for review October 24, 2024 11:53
@ilija42 ilija42 requested review from a team as code owners October 24, 2024 11:53
@ilija42 ilija42 marked this pull request as draft October 24, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant