Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrapper improvements #14910

Open
wants to merge 4 commits into
base: dk/rmn-integ-test
Choose a base branch
from

Conversation

0xnogo
Copy link
Collaborator

@0xnogo 0xnogo commented Oct 23, 2024

No description provided.

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Oct 23, 2024

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Core Tests (go_core_tests) , lint , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , SonarQube Scan , Flakey Test Detection

1. Connection refused error in test:

Error: Connection refused error in test:[Run tests]

Source of Error:
Run tests	2024-10-24T06:59:05.8222655Z �[0;31m 	 	Post "http://localhost:52066": dial tcp [::1]:52066: connect: connection refused �[0m
**Why**: The test is attempting to make an HTTP POST request to a local server running on port 52066, but the connection is being refused, indicating that the server is not running or not accessible at the specified address and port.

Suggested fix: Ensure that the server is correctly started and listening on the specified port before running the test. Verify the server configuration and network settings.

2. Mismatched expected and actual values in test:

Error: Mismatched expected and actual values in test:[Run tests]

Source of Error:
Run tests	2024-10-24T06:59:05.8226524Z �[0;31m 	Error Trace:	/home/runner/work/chainlink/chainlink/core/capabilities/ccip/ccipevm/rmncrypto_test.go:177 �[0m
Run tests	2024-10-24T06:59:05.8229021Z �[0;31m 	Error: 	Not equal: �[0m
Run tests	2024-10-24T06:59:05.8235483Z �[0;31m 	 	expected: []interface {}{[32]uint8{0x96, 0x51, 0x94, 0x37, 0x83, 0xdb, 0xf8, 0x19, 0x35, 0xa6, 0xe, 0x98, 0xf2, 0x18, 0xa9, 0xd9, 0xb5, 0xb2, 0x88, 0x23, 0xfb, 0x22, 0x28, 0xbb, 0xd9, 0x13, 0x20, 0xd6, 0x32, 0xfa, 0xcf, 0x53}, struct { DestChainId *big.Int "json:\"destChainId\""; DestChainSelector uint64 "json:\"destChainSelector\""; RmnRemoteContractAddress common.Address "json:\"rmnRemoteContractAddress\""; OfframpAddress common.Address "json:\"offrampAddress\""; RmnHomeContractConfigDigest [32]uint8 "json:\"rmnHomeContractConfigDigest\""; MerkleRoots []struct { SourceChainSelector uint64 "json:\"sourceChainSelector\""; OnRampAddress []uint8 "json:\"onRampAddress\""; MinSeqNr uint64 "json:\"minSeqNr\""; MaxSeqNr uint64 "json:\"maxSeqNr\""; MerkleRoot [32]uint8 "json:\"merkleRoot\"" } "json:\"merkleRoots\"" }{DestChainId:2337, DestChainSelector:0xb356733e229244f2, RmnRemoteContractAddress:0x5370F78c6af2Da9cF6642382A3a75F9D5aEc9cc1, OfframpAddress:0xAd5d57aD9bB17d34Debb88566ab2F5dB879Cc4 �[0m
Run tests	2024-10-24T06:59:05.8246371Z 6F, RmnHomeContractConfigDigest:[32]uint8{0x0, 0xb, 0xbe, 0x6e, 0x44, 0x3f, 0xee, 0xa6, 0x39, 0xd9, 0x87, 0x8c, 0xac, 0x4b, 0x4e, 0x98, 0xf5, 0x9b, 0xc, 0x18, 0x69, 0xdd, 0x60, 0x16, 0x3a, 0xd7, 0x6f, 0x76, 0xfb, 0xa5, 0xcb, 0x7f}, MerkleRoots:[]struct { SourceChainSelector uint64 "json:\"sourceChainSelector\""; OnRampAddress []uint8 "json:\"onRampAddress\""; MinSeqNr uint64 "json:\"minSeqNr\""; MaxSeqNr uint64 "json:\"maxSeqNr\""; MerkleRoot [32]uint8 "json:\"merkleRoot\"" }{struct { SourceChainSelector uint64 "json:\"sourceChainSelector\""; OnRampAddress []uint8 "json:\"onRampAddress\""; MinSeqNr uint64 "json:\"minSeqNr\""; MaxSeqNr uint64 "json:\"maxSeqNr\""; MerkleRoot [32]uint8 "json:\"merkleRoot\"" }{SourceChainSelector:0x2ee634951ef71b46, OnRampAddress:[]uint8{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x7a, 0x20, 0x88, 0xa1, 0xbf, 0xc9, 0xd8, 0x1c, 0x55, 0x36, 0x8a, 0xe1, 0x68, 0xc2, 0xc0, 0x25, 0x70, 0xcb, 0x81, 0x4f}, MinSeqNr:0x1, MaxSeqNr:0x1, MerkleRoot:[32]uint8{0x1c, 0x61, 0xfe, 0xf7, 0xa3, 0xdd, 0x15, 0x39, 0x43, 0x41, 0x9c, 0x11, 0x1, 0x3, 0x13, 0x16, 0xed, 0x7b, 0x7a, 0x3d, 0x75, 0x91, 0x3c, 0x34, 0xcb, 0xe8, 0x62, 0x80, 0x33, 0xf5, 0x92, 0x4f}}}}}
Run tests	2024-10-24T06:59:05.8258784Z �[0;31m 	 	actual : []interface {}{[32]uint8{0x96, 0x51, 0x94, 0x37, 0x83, 0xdb, 0xf8, 0x19, 0x35, 0xa6, 0xe, 0x98, 0xf2, 0x18, 0xa9, 0xd9, 0xb5, 0xb2, 0x88, 0x23, 0xfb, 0x22, 0x28, 0xbb, 0xd9, 0x13, 0x20, 0xd6, 0x32, 0xfa, 0xcf, 0x53}, struct { DestChainId *big.Int "json:\"destChainId\""; DestChainSelector uint64 "json:\"destChainSelector\""; RmnRemoteContractAddress common.Address "json:\"rmnRemoteContractAddress\""; OfframpAddress common.Address "json:\"offrampAddress\""; RmnHomeContractConfigDigest [32]uint8 "json:\"rmnHomeContractConfigDigest\""; MerkleRoots []struct { SourceChainSelector uint64 "json:\"sourceChainSelector\""; OnRampAddress []uint8 "json:\"onRampAddress\""; MinSeqNr uint64 "json:\"minSeqNr\""; MaxSeqNr uint64 "json:\"maxSeqNr\""; MerkleRoot [32]uint8 "json:\"merkleRoot\"" } "json:\"merkleRoots\"" }{DestChainId:2337, DestChainSelector:0xb356733e229244f2, RmnRemoteContractAddress:0x0Cf17D5DcDA9cF25889cEc9ae5610B0FB9725F65, OfframpAddress:0xAd5d57aD9bB17d34Debb88566ab2F5dB879Cc4 �[0m
Run tests	2024-10-24T06:59:05.8269572Z 6F, RmnHomeContractConfigDigest:[32]uint8{0x0, 0xb, 0xbe, 0x6e, 0x44, 0x3f, 0xee, 0xa6, 0x39, 0xd9, 0x87, 0x8c, 0xac, 0x4b, 0x4e, 0x98, 0xf5, 0x9b, 0xc, 0x18, 0x69, 0xdd, 0x60, 0x16, 0x3a, 0xd7, 0x6f, 0x76, 0xfb, 0xa5, 0xcb, 0x7f}, MerkleRoots:[]struct { SourceChainSelector uint64 "json:\"sourceChainSelector\""; OnRampAddress []uint8 "json:\"onRampAddress\""; MinSeqNr uint64 "json:\"minSeqNr\""; MaxSeqNr uint64 "json:\"maxSeqNr\""; MerkleRoot [32]uint8 "json:\"merkleRoot\"" }{struct { SourceChainSelector uint64 "json:\"sourceChainSelector\""; OnRampAddress []uint8 "json:\"onRampAddress\""; MinSeqNr uint64 "json:\"minSeqNr\""; MaxSeqNr uint64 "json:\"maxSeqNr\""; MerkleRoot [32]uint8 "json:\"merkleRoot\"" }{SourceChainSelector:0x2ee634951ef71b46, OnRampAddress:[]uint8{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x7a, 0x20, 0x88, 0xa1, 0xbf, 0xc9, 0xd8, 0x1c, 0x55, 0x36, 0x8a, 0xe1, 0x68, 0xc2, 0xc0, 0x25, 0x70, 0xcb, 0x81, 0x4f}, MinSeqNr:0x1, MaxSeqNr:0x1, MerkleRoot:[32]uint8{0x1c, 0x61, 0xfe, 0xf7, 0xa3, 0xdd, 0x15, 0x39, 0x43, 0x41, 0x9c, 0x11, 0x1, 0x3, 0x13, 0x16, 0xed, 0x7b, 0x7a, 0x3d, 0x75, 0x91, 0x3c, 0x34, 0xcb, 0xe8, 0x62, 0x80, 0x33, 0xf5, 0x92, 0x4f}}}}}
**Why**: The test is failing because the actual output does not match the expected output. This could be due to changes in the data, incorrect test setup, or a bug in the code being tested.

Suggested fix: Review the test case and the expected values. Ensure that the test setup is correct and that the expected values are accurate. If the code has changed, update the test to reflect the new expected behavior.

3. GolangCI-Lint error:

Error: GolangCI-Lint error:[Golang Lint]

Source of Error:
Golang Lint	2024-10-24T06:52:34.9883383Z ##[error]core/capabilities/ccip/oraclecreator/bootstrap.go:347:2: Consider pre-allocating `actions` (prealloc)
Golang Lint	2024-10-24T06:52:34.9884772Z 	var actions []syncAction
Golang Lint	2024-10-24T06:52:34.9885313Z 	^
**Why**: The linter is suggesting that the `actions` slice should be pre-allocated to improve performance. This is a common optimization to avoid multiple allocations as the slice grows.

Suggested fix: Pre-allocate the actions slice with an appropriate capacity if the size is known or can be reasonably estimated. For example:

actions := make([]syncAction, 0, estimatedSize)

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@0xnogo 0xnogo marked this pull request as ready for review October 23, 2024 12:36
@0xnogo 0xnogo requested a review from a team as a code owner October 23, 2024 12:36
@0xnogo 0xnogo requested review from winder, rstout, asoliman92, makramkd, dimkouv and mateusz-sekara and removed request for a team October 23, 2024 12:36
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@0xnogo 0xnogo changed the base branch from dk/rmn-integ-test to dk/rmn-integration-test October 24, 2024 08:55
@0xnogo 0xnogo requested review from a team as code owners October 24, 2024 08:55
@0xnogo 0xnogo requested review from ilija42 and removed request for a team October 24, 2024 08:55
@0xnogo 0xnogo changed the base branch from dk/rmn-integration-test to dk/rmn-integ-test October 24, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants