Add telemetry #235
Closed
Add telemetry #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirenko
force-pushed
the
CCIP-1174/ccip-telemetry
branch
12 times, most recently
from
52efc68 to
3bb1bc0
Compare
sirenko
force-pushed
the
CCIP-1174/ccip-telemetry
branch
4 times, most recently
from
106af85 to
d3f4269
Compare
mateusz-sekara
requested changes
Nov 3, 2023
core/services/ocr2/plugins/ccip/execution_reporting_plugin_test.go
Outdated
Show resolved
Hide resolved
sirenko
force-pushed
the
CCIP-1174/ccip-telemetry
branch
2 times, most recently
from
a977699 to
ed243ca
Compare
sirenko
force-pushed
the
CCIP-1174/ccip-telemetry
branch
from
7c408f5 to
ef2baa7
Compare
* Initial draft * Add manager * Update config TOML * Update config tests * Add telemetry manager tests * Fix lint * Add CHANGELOG.md * Update TelemetryService Send interface * Fix bad merge * Fix hanging tests * Change config from TelemetryIngressEndpoint to TelemetryIngress.Endpoints * - Fix wrong context being passed * - Remove protocol prefix from telemetry URL - Drop context from TelemPayload * - Fix context in tests * - Update CHANGELOG.md * - Add fields back and show error * - Fix failing tests * Move changelog entry to [dev] * Update so that telemetry can still be configured the old way * Update CONFIG.md
sirenko
force-pushed
the
CCIP-1174/ccip-telemetry
branch
from
ef2baa7 to
89d4c4e
Compare
sirenko
force-pushed
the
CCIP-1174/ccip-telemetry
branch
from
89d4c4e to
1eece29
Compare
sirenko
force-pushed
the
CCIP-1174/ccip-telemetry
branch
from
e12ac39 to
a164043
Compare
sirenko
force-pushed
the
CCIP-1174/ccip-telemetry
branch
from
a164043 to
a52a9d4
Compare
mateusz-sekara
approved these changes
Nov 8, 2023
|
@sirenko need to fix the following issues: |
|
Need to add import |
sirenko
force-pushed
the
CCIP-1174/ccip-telemetry
branch
5 times, most recently
from
95df5a4 to
3573feb
Compare
connorwstein
reviewed
Nov 8, 2023
core/services/ocr2/plugins/ccip/execution_reporting_plugin_test.go
Outdated
Show resolved
Hide resolved
sirenko
force-pushed
the
CCIP-1174/ccip-telemetry
branch
4 times, most recently
from
6436878 to
b290c09
Compare
sirenko
force-pushed
the
CCIP-1174/ccip-telemetry
branch
from
b290c09 to
a4b0533
Compare
sirenko
force-pushed
the
CCIP-1174/ccip-telemetry
branch
from
a4b0533 to
77e867b
Compare
|
Stashing for now. See CCIP-1174 for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution