-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menubar material #1070
Menubar material #1070
Conversation
…to menubar-material
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/smaranjitghose/doc2pen/4PJ8WN3zTjHyrD5K9yeQYcTsMykw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goyal-Dushi there are some changes that I would recommend
-
The image that you have used for line spacing is slightly bigger than the other images that you have used. Please try to make it of the same height as the other images.
-
Also the input field where you are showing the line-spacing value, can you expand it a bit to fit all the characters. I have attached an image below that shows the current display.
Hey @AbhipsaGuru1012, I have added your recommended changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double-clicking it goes away. So try resolving that cause if the user sets something and clicks it again it shouldn't go away.
import { Tooltip, Avatar } from "@material-ui/core"; | ||
import { withStyles, makeStyles } from "@material-ui/core"; | ||
|
||
const CustomTooltip = withStyles({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be defined in CSS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @anushbhatia, these are all material imports, thus, they are imported within the component jsx. Check below for the usage.
https://material-ui.com/getting-started/usage/
Actually, I have made it so that the user could toggle through it. The user is supposed to click the option once in order to get the option to set values. If you want the option to remain after a single click then no problem, I can add so. |
Hey, @smaranjitghose, I see you have closed the pull request, I can still customize the layout if you want and the overlap issue if you are accepting the pull request. |
Addressing issue #1059.
Designed the Editor UI using material and CSS
editMenuUI.mp4