Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nonspec: Add Pavel to maintainers #1271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcelamelara
Copy link
Contributor

Requesting to add @paveliak as a maintainer. He contributes as co-shepherd of the attested build environment track, so being able to manage issues and approve PRs in this track would be really helpful.

Signed-off-by: Marcela Melara <[email protected]>
Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for slsa canceled.

Name Link
🔨 Latest commit c647684
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/677d5377f347f40008517d1f

@TomHennen
Copy link
Contributor

I think my only qualm, if I'm going to be especially pedantic, is that I can't find much public contribution from @paveliak to this project?

Am I

a) doing it wrong, you can see everything he's contributed HERE?
b) being too strict, Pavel has contributed in other spaces, and that's totally inline with maintainership?
c) other?

Copy link
Member

@mlieberman85 mlieberman85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomHennen
Copy link
Contributor

I think my only qualm, if I'm going to be especially pedantic, is that I can't find much public contribution from @paveliak to this project?

Am I

a) doing it wrong, you can see everything he's contributed HERE? b) being too strict, Pavel has contributed in other spaces, and that's totally inline with maintainership? c) other?

Seeing as how no one else is concerned, I'll retract my (minor) objection.

Welcome Pavel!

@lehors
Copy link
Member

lehors commented Jan 13, 2025

I actually feel a bit the same as Tom. It seems a bit odd to make someone who hasn't made a single commit a maintainer and doesn't show up in the list of contributors at all. This said, making a commit isn't a requirement. Our doc states that:

The criteria for becoming a Maintainer is documented in the SLSA Governance repository and copied here for convenience:

Demonstrated track record of PR reviews (both quality and quantity of reviews)
Demonstrated thought leadership in the project
Demonstrated shepherding of project work and contributors

The best way to get started is to regularly contribute and review pull requests.

So, as long as the above is true it is fine, but it might be worth making that claim explicit.
Note that I don't mean to be difficult, it's just a matter of fairness to other community members who may want to become maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

7 participants