-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nonspec: Add Pavel to maintainers #1271
base: main
Are you sure you want to change the base?
nonspec: Add Pavel to maintainers #1271
Conversation
Signed-off-by: Marcela Melara <[email protected]>
✅ Deploy Preview for slsa canceled.
|
I think my only qualm, if I'm going to be especially pedantic, is that I can't find much public contribution from @paveliak to this project? Am I a) doing it wrong, you can see everything he's contributed HERE? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Seeing as how no one else is concerned, I'll retract my (minor) objection. Welcome Pavel! |
I actually feel a bit the same as Tom. It seems a bit odd to make someone who hasn't made a single commit a maintainer and doesn't show up in the list of contributors at all. This said, making a commit isn't a requirement. Our doc states that:
So, as long as the above is true it is fine, but it might be worth making that claim explicit. |
Requesting to add @paveliak as a maintainer. He contributes as co-shepherd of the attested build environment track, so being able to manage issues and approve PRs in this track would be really helpful.