content: refine dependency threats #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refine the "dependency threats" of the Threats & Mitigations page to better explain the intent and to differentiate from (H), which sounded confusingly similar (slsa-framework#1039). More work is needed to refine (H), but that is left to a separate PR. - Explain that "dependency threats" are not distinct threats but rather threats to other pieces of software that also affect this one. In the diagram, the diagram to color (D) differently to show this, mirroring the existing dashed lines. - State that only "build dependencies" are in scope for the threat model, matching existing diagram and terminology throughout SLSA. - Rename "Use compromised dependency" to "Compromise build dependency", both for consistency with other threats, which are from the adversary's point of view, and to emphasize that this is restricted to build dependencies. - Expand the text about dependency threats and give examples. Highlight both "include" and "build tool" types of dependencies, and also include both an accidental vulnerability and a malicious backdoor. Signed-off-by: Mark Lodato <[email protected]>
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I'm interested in feedback from folks to see if this is a step in the right direction. |
kpk47
reviewed
Apr 15, 2024
MarkLodato
force-pushed
the
threats-d-h-1039
branch
2 times, most recently
from
0b9a75d to
c75aa13
Compare
Signed-off-by: Mark Lodato <[email protected]>
meder
reviewed
Apr 24, 2024
kpk47
reviewed
Apr 24, 2024
kpk47
approved these changes
Apr 24, 2024
Signed-off-by: Mark Lodato <[email protected]>
Signed-off-by: Mark Lodato <[email protected]>
jkjell
reviewed
Apr 30, 2024
meder
approved these changes
Apr 30, 2024
joshuagl
approved these changes
May 1, 2024
Co-authored-by: Joshua Lock <[email protected]> Signed-off-by: Mark Lodato <[email protected]>
Co-authored-by: John Kjell <[email protected]> Signed-off-by: Mark Lodato <[email protected]>
joshuagl
approved these changes
May 2, 2024
arewm
approved these changes
May 2, 2024
There was a problem hiding this comment.
Nit: The original issue #1039 mentions confusion between the distinction of a consumer as something potentially separate from a dependency relationship.
We can make it more apparent that a dependency is a form of a consumer relationship.
Signed-off-by: Mark Lodato <[email protected]>
MarkLodato
commented
May 3, 2024
Nikokrock
pushed a commit
to Nikokrock/slsa
that referenced
this pull request
Jun 13, 2024
Refine the "dependency threats" of the Threats & Mitigations page to better explain the intent and to differentiate from (H), which sounded confusingly similar (slsa-framework#1039). More work is needed to refine (H), but that is left to a separate PR. - Explain that "dependency threats" are not distinct threats but rather threats to other pieces of software that also affect this one. In the diagram, the diagram to color (D) differently to show this, mirroring the existing dashed lines, and add "(A-H recursively"). - State that only "build dependencies" are in scope for the threat model, matching existing diagram and terminology throughout SLSA. - Rename "Use compromised dependency" to "Compromise build dependency", both for consistency with other threats, which are from the adversary's point of view, and to emphasize that this is restricted to build dependencies. - Expand the text about dependency threats and give examples. Highlight both "include" and "build tool" types of dependencies, and also include both an accidental vulnerability and a malicious backdoor. Signed-off-by: Mark Lodato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine the "dependency threats" of the Threats & Mitigations page to
better explain the intent and to differentiate from (H), which sounded
confusingly similar (#1039). More work is needed to refine (H), but that
is left to a separate PR.
rather threats to other pieces of software that also affect this
one. In the diagram, the diagram to color (D) differently to show
this, mirroring the existing dashed lines, and add "(A-H
recursively").
model, matching existing diagram and terminology throughout SLSA.
dependency", both for consistency with other threats, which are from
the adversary's point of view, and to emphasize that this is
restricted to build dependencies.
Highlight both "include" and "build tool" types of dependencies, and
also include both an accidental vulnerability and a malicious
backdoor.