Modernize the development environment #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This must have been a relic from long ago because it sure doesn't seem used or useful at this point.
Mocah and Should are only used for testing purposes and absolutely do not belong as a core dependency. Issue #15 Modernize development environment
I honestly don't know when this got removed, but, that's why Travis has been breaking this whole time I bet. Issue #15 Modernize development environment
Travis might as well test on 11.0.1 Issue #15 Modernize development environment
slifty
force-pushed
the
15-modernize-dev-environment
branch
from
de958fe to
1479ed6
Compare
The project was using a very old version of Mocah and should packages. This brings them up to the current stable versions of each. This actually exposed a mistake in the tests as written, which forgot to properly close the Opened Captions server before declaring the tests over in some cases. The tests still have an issue, which also exposes a mistake that will need to be fixed in a separate commit. Issue #15 Modernize development environment
Opened Captions has a close method which, in theory, should stop its operations. It turns out it actually didn't, and in the case of the random stream the interval kept going even after a close command was issued. This fixes this oversight, and also means that the unit tests properly end. The reason this got noticed is that about a year ago Mocha decided to no longer automatically terminate the test process. You can read more about that https://boneskull.com/mocha-v4-nears-release/#mochawontforceexit
Another exposed mistake thanks to Mocha's change to process killing (I'm glad they made that change to be honest...) The tests which created a SocketIO client to test opened captions were passing, and then failing because after they ended the opened captions server closed but the client was not disconnected first. This change disconnects the client before turning off the server.
slifty
force-pushed
the
15-modernize-dev-environment
branch
from
1479ed6 to
ca24a85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a whole slew of little nits with the code base.
Travis should now be working properly and the two testing packages have been updated to the most recent versions. This actually revealed some issues with the tests themselves as well as one issue with the code base (the random stream had an interval that never got closed)
Also switching over to use yarn in travis, and removes the setting of a specific node version from the travis config.
This touches on some of the items in #15 but does not resolve it completely.