chore: address clippy warnings

src/buffer_callback.rs

@@ -6,7 +6,7 @@ use crate::{
 };
 
 static mut BUFFER_CALLBACKS: Lazy<CronetCallbacks<Cronet_BufferCallbackPtr, BufferCallbackFn>> =
-    Lazy::new(|| CronetCallbacks::new());
+    Lazy::new(CronetCallbacks::new);
 
 #[no_mangle]
 unsafe extern "C" fn cronetBufferCallbackOnDestroy(

src/client/client.rs

@@ -84,3 +84,9 @@ impl Client {
         }
     }
 }
+
+impl Default for Client {
+    fn default() -> Self {
+        Self::new()
+    }
+}

src/client/mod.rs

@@ -1,5 +1,6 @@
 mod body;
 mod body_upload_provider;
+#[allow(clippy::module_inception)]
 mod client;
 mod error;
 mod response_handler;

src/client/response_handler.rs

@@ -102,7 +102,7 @@ impl UrlRequestCallbackHandler for ResponseHandler {
 
     fn on_succeeded(&mut self, _: UrlRequestCallback, req: UrlRequest, _: UrlResponseInfo) {
         req.destroy();
-        let response = mem::replace(&mut self.response, Response::default());
+        let response = mem::take(&mut self.response);
         self.tx.send(Status::Success(response)).unwrap();
     }
 

src/date_time.rs

@@ -48,6 +48,12 @@ impl Destroy for DateTime {
     }
 }
 
+impl Default for DateTime {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use std::time::UNIX_EPOCH;

src/engine.rs

@@ -110,6 +110,12 @@ impl Destroy for Engine {
     }
 }
 
+impl Default for Engine {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use crate::Destroy;

src/engine_params.rs

@@ -273,6 +273,12 @@ impl Destroy for EngineParams {
     }
 }
 
+impl Default for EngineParams {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 #[derive(Debug, PartialEq)]
 pub enum HttpCacheMode {
     /// Disable HTTP cache.

src/error.rs

@@ -116,6 +116,12 @@ impl Destroy for CronetError {
     }
 }
 
+impl Default for CronetError {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl fmt::Display for CronetError {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         write!(

src/executor.rs

@@ -6,7 +6,7 @@ use crate::{
 };
 
 static mut EXECUTOR_CALLBACKS: Lazy<CronetCallbacks<Cronet_ExecutorPtr, ExecutorExecuteFn>> =
-    Lazy::new(|| CronetCallbacks::new());
+    Lazy::new(CronetCallbacks::new);
 
 #[no_mangle]
 unsafe extern "C" fn cronetExecutorOnExecute(

src/http_header.rs

@@ -58,6 +58,12 @@ impl Destroy for HttpHeader {
     }
 }
 
+impl Default for HttpHeader {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use crate::Destroy;

src/metrics.rs

@@ -161,24 +161,15 @@ impl Metrics {
     }
 
     pub fn socket_reused(&self) -> bool {
-        unsafe {
-            let reused = Cronet_Metrics_socket_reused_get(self.ptr);
-            reused
-        }
+        unsafe { Cronet_Metrics_socket_reused_get(self.ptr) }
     }
 
     pub fn sent_byte_count(&self) -> i64 {
-        unsafe {
-            let count = Cronet_Metrics_sent_byte_count_get(self.ptr);
-            count
-        }
+        unsafe { Cronet_Metrics_sent_byte_count_get(self.ptr) }
     }
 
     pub fn received_byte_count(&self) -> i64 {
-        unsafe {
-            let count = Cronet_Metrics_received_byte_count_get(self.ptr);
-            count
-        }
+        unsafe { Cronet_Metrics_received_byte_count_get(self.ptr) }
     }
 
     pub fn set_request_start(&self, datetime: DateTime) {
@@ -284,6 +275,12 @@ impl Destroy for Metrics {
     }
 }
 
+impl Default for Metrics {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use std::time::SystemTime;

src/public_key_pins.rs

@@ -111,6 +111,12 @@ impl Destroy for PublicKeyPins {
     }
 }
 
+impl Default for PublicKeyPins {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use std::time::UNIX_EPOCH;

src/quic_hint.rs

@@ -65,6 +65,12 @@ impl Destroy for QuicHint {
     }
 }
 
+impl Default for QuicHint {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use crate::Destroy;

src/request_finished_info.rs

@@ -87,6 +87,12 @@ impl Destroy for RequestFinishedInfo {
     }
 }
 
+impl Default for RequestFinishedInfo {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 /// Enum representing the reason why the request finished.
 #[derive(Debug, PartialEq)]
 pub enum RequestFinishedInfoReason {

src/request_finished_info_listener.rs

@@ -10,7 +10,7 @@ use crate::{
 
 static mut REQUEST_FINISHED_INFO_LISTENER_CALLBACKS: Lazy<
     CronetCallbacks<Cronet_RequestFinishedInfoListenerPtr, OnRequestFinishedFn>,
-> = Lazy::new(|| CronetCallbacks::new());
+> = Lazy::new(CronetCallbacks::new);
 
 #[no_mangle]
 unsafe extern "C" fn cronetOnRequestFinished(
@@ -50,10 +50,9 @@ impl RequestFinishedInfoListener {
         }
     }
 
-    pub fn set_client_context(&self, raw_data: Cronet_RawDataPtr) {
-        unsafe {
-            Cronet_RequestFinishedInfoListener_SetClientContext(self.ptr, raw_data);
-        }
+    #[allow(clippy::missing_safety_doc)]
+    pub unsafe fn set_client_context(&self, raw_data: Cronet_RawDataPtr) {
+        Cronet_RequestFinishedInfoListener_SetClientContext(self.ptr, raw_data);
     }
 }
 
@@ -84,7 +83,9 @@ mod tests {
     #[test]
     fn it_sets_client_context() {
         let listener = super::RequestFinishedInfoListener::new(|_, _, _, _| {});
-        listener.set_client_context(std::ptr::null_mut());
+        unsafe {
+            listener.set_client_context(std::ptr::null_mut());
+        }
         listener.destroy();
     }
 }

src/runnable.rs

@@ -6,7 +6,7 @@ use crate::{
 };
 
 static mut RUNNABLE_CALLBACKS: Lazy<CronetCallbacks<Cronet_RunnablePtr, RunnableRunFn>> =
-    Lazy::new(|| CronetCallbacks::new());
+    Lazy::new(CronetCallbacks::new);
 
 #[no_mangle]
 unsafe extern "C" fn cronetRunnableOnRun(selfPtr: Cronet_RunnablePtr) {

src/upload_data_provider.rs

@@ -11,15 +11,15 @@ use crate::{
 
 static mut UPLOAD_DATA_PROVIDER_CALLBACKS: Lazy<
     CronetCallbacks<Cronet_UploadDataProviderPtr, Box<dyn UploadDataProviderHandler>>,
-> = Lazy::new(|| CronetCallbacks::new());
+> = Lazy::new(CronetCallbacks::new);
 
 #[no_mangle]
 unsafe extern "C" fn cronetUploadDataProviderGetLength(
     selfPtr: Cronet_UploadDataProviderPtr,
 ) -> i64 {
     let lockedMap = UPLOAD_DATA_PROVIDER_CALLBACKS.map().lock().unwrap();
     let callback = lockedMap.get(&selfPtr).unwrap();
-    return callback.length(UploadDataProvider { ptr: selfPtr });
+    callback.length(UploadDataProvider { ptr: selfPtr })
 }
 
 #[no_mangle]
@@ -105,8 +105,9 @@ impl UploadDataProvider {
         }
     }
 
-    pub fn set_client_context(&self, client_context: Cronet_ClientContext) {
-        unsafe { Cronet_UploadDataProvider_SetClientContext(self.ptr, client_context) }
+    #[allow(clippy::missing_safety_doc)]
+    pub unsafe fn set_client_context(&self, client_context: Cronet_ClientContext) {
+        Cronet_UploadDataProvider_SetClientContext(self.ptr, client_context)
     }
 
     pub fn client_context(&self) -> Cronet_ClientContext {

src/upload_data_sink.rs

@@ -11,7 +11,7 @@ use crate::{
 
 static mut UPLOAD_DATA_SINK_CALLBACKS: Lazy<
     CronetCallbacks<Cronet_UploadDataSinkPtr, UploadDataSinkCallbacks>,
-> = Lazy::new(|| CronetCallbacks::new());
+> = Lazy::new(CronetCallbacks::new);
 
 #[no_mangle]
 unsafe extern "C" fn cronetUploadDataSinkOnReadSucceeded(

src/url_request.rs

@@ -134,3 +134,9 @@ impl Destroy for UrlRequest {
         }
     }
 }
+
+impl Default for UrlRequest {
+    fn default() -> Self {
+        Self::new()
+    }
+}

src/url_request_callback.rs

@@ -11,7 +11,7 @@ use crate::{
 
 static mut URL_REQUEST_CALLBACK_CALLBACKS: Lazy<
     CronetCallbacks<Cronet_UrlRequestCallbackPtr, Box<dyn UrlRequestCallbackHandler>>,
-> = Lazy::new(|| CronetCallbacks::new());
+> = Lazy::new(CronetCallbacks::new);
 
 #[no_mangle]
 unsafe extern "C" fn cronetUrlRequestCallbackOnRedirectReceived(

src/url_request_params.rs

@@ -270,6 +270,12 @@ impl Destroy for UrlRequestParams {
     }
 }
 
+impl Default for UrlRequestParams {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 #[cfg(feature = "client")]
 impl<T> From<Request<T>> for UrlRequestParams
 where

src/url_request_status_listener.rs

@@ -8,7 +8,7 @@ use crate::{
 
 static mut URL_REQUEST_STATUS_LISTENER_CALLBACKS: Lazy<
     CronetCallbacks<Cronet_UrlRequestStatusListenerPtr, UrlRequestStatusListenerOnStatusFn>,
-> = Lazy::new(|| CronetCallbacks::new());
+> = Lazy::new(CronetCallbacks::new);
 
 #[no_mangle]
 unsafe extern "C" fn cronetUrlRequestStatusListenerOnStatus(
@@ -53,6 +53,12 @@ impl Destroy for UrlRequestStatusListener {
     }
 }
 
+impl Default for UrlRequestStatusListener {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 /// Enum representing the status of a [crate::UrlRequest].
 #[derive(Debug, PartialEq)]
 pub enum UrlRequestStatus {

src/url_response_info.rs

@@ -109,10 +109,7 @@ impl UrlResponseInfo {
     }
 
     pub fn header_size(&self) -> u32 {
-        unsafe {
-            let size = Cronet_UrlResponseInfo_all_headers_list_size(self.ptr);
-            size
-        }
+        unsafe { Cronet_UrlResponseInfo_all_headers_list_size(self.ptr) }
     }
 
     pub fn header_at(&self, index: u32) -> HttpHeader {
@@ -200,7 +197,14 @@ impl Destroy for UrlResponseInfo {
     }
 }
 
+impl Default for UrlResponseInfo {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 #[cfg(feature = "client")]
+#[allow(clippy::from_over_into)]
 impl<T> Into<Response<T>> for UrlResponseInfo
 where
     T: Default,