Skip to content

Commit

Permalink
Remove unused accompanist deps (#1848)
Browse files Browse the repository at this point in the history
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[com.google.accompanist:accompanist-permissions](https://redirect.github.com/google/accompanist)
| dependencies | minor | `0.36.0` -> `0.37.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>google/accompanist
(com.google.accompanist:accompanist-permissions)</summary>

###
[`v0.37.0`](https://redirect.github.com/google/accompanist/releases/tag/v0.37.0):
🌈

#### What’s Changed

- Release v0.37.0
([#&#8203;1812](https://redirect.github.com/google/accompanist/issues/1812))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Convert samples to M3 and edge to edge
([#&#8203;1810](https://redirect.github.com/google/accompanist/issues/1810))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Convert sample app activity to Compose
([#&#8203;1807](https://redirect.github.com/google/accompanist/issues/1807))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Remove Navigation Animation
([#&#8203;1808](https://redirect.github.com/google/accompanist/issues/1808))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Remove system ui controller
([#&#8203;1809](https://redirect.github.com/google/accompanist/issues/1809))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Remove Navigation Material
([#&#8203;1806](https://redirect.github.com/google/accompanist/issues/1806))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Remove Test Harness
([#&#8203;1805](https://redirect.github.com/google/accompanist/issues/1805))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Fix issue bundling kotlin metadataJvm in permissions lint
([#&#8203;1804](https://redirect.github.com/google/accompanist/issues/1804))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Upgrade to Kotlin 2.0.20 and move to build-logic for Gradle
([#&#8203;1802](https://redirect.github.com/google/accompanist/issues/1802))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- \[Permissions] Support calling rememberPermissionState in a Compose
preview
([#&#8203;1803](https://redirect.github.com/google/accompanist/issues/1803))
[@&#8203;eygraber](https://redirect.github.com/eygraber)
- Remove insets-ui
([#&#8203;1801](https://redirect.github.com/google/accompanist/issues/1801))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Remove Web
([#&#8203;1800](https://redirect.github.com/google/accompanist/issues/1800))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Remove Placeholder
([#&#8203;1799](https://redirect.github.com/google/accompanist/issues/1799))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Remove ThemeAdapter
([#&#8203;1798](https://redirect.github.com/google/accompanist/issues/1798))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Remove SwipeRefresh
([#&#8203;1797](https://redirect.github.com/google/accompanist/issues/1797))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Remove Pager
([#&#8203;1796](https://redirect.github.com/google/accompanist/issues/1796))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Remove FlowLayout library
([#&#8203;1795](https://redirect.github.com/google/accompanist/issues/1795))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- \[Permissions]
fix([gh-1781](https://redirect.github.com/google/accompanist/issues/1781)):
check for `Denied(shouldShowRationale=false)` in
`MutableMultiplePermissionsState.shouldShowRationale`
([#&#8203;1783](https://redirect.github.com/google/accompanist/issues/1783))
[@&#8203;FelixZY](https://redirect.github.com/FelixZY)
- Update update-release.yml
([#&#8203;1792](https://redirect.github.com/google/accompanist/issues/1792))
[@&#8203;bentrengrove](https://redirect.github.com/bentrengrove)
- Fix insets-ui migration step
([#&#8203;1791](https://redirect.github.com/google/accompanist/issues/1791))
[@&#8203;alexvanyo](https://redirect.github.com/alexvanyo)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS42OS4zIiwidXBkYXRlZEluVmVyIjoiMzkuNjkuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

---------

Co-authored-by: Zac Sweers <[email protected]>
  • Loading branch information
slack-oss-bot and ZacSweers authored Dec 25, 2024
1 parent e8a638a commit 2648322
Show file tree
Hide file tree
Showing 9 changed files with 2 additions and 32 deletions.
2 changes: 1 addition & 1 deletion circuit-shared-elements/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,6 @@ android { namespace = "com.slack.circuit.sharedelements" }
baselineProfile {
mergeIntoMain = true
saveInSrc = true
from(projects.samples.star.benchmark.dependencyProject)
@Suppress("DEPRECATION") from(projects.samples.star.benchmark.dependencyProject)
filter { include("com.slack.circuit.sharedelements.**") }
}
7 changes: 1 addition & 6 deletions circuitx/overlays/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,7 @@ kotlin {
}
}

androidMain {
dependencies {
api(libs.androidx.compose.material.material3)
implementation(libs.androidx.compose.accompanist.systemUi)
}
}
androidMain { dependencies { api(libs.androidx.compose.material.material3) } }
// We use a common folder instead of a common source set because there is no commonizer
// which exposes the browser APIs across these two targets.
jsMain { kotlin.srcDir("src/browserMain/kotlin") }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ androidx.savedstate:savedstate
androidx.startup:startup-runtime
androidx.tracing:tracing
androidx.versionedparcelable:versionedparcelable
com.google.accompanist:accompanist-systemuicontroller
com.google.guava:listenablefuture
org.jetbrains.androidx.lifecycle:lifecycle-common
org.jetbrains.androidx.lifecycle:lifecycle-runtime-compose
Expand Down
10 changes: 0 additions & 10 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
[versions]
accompanist = "0.36.0"
androidx-activity = "1.9.3"
androidx-annotation = "1.9.1"
androidx-appcompat = "1.7.0"
Expand Down Expand Up @@ -95,15 +94,6 @@ androidx-appCompat = { module = "androidx.appcompat:appcompat", version.ref = "a
androidx-benchmark-macro-junit = { module = "androidx.benchmark:benchmark-macro-junit4", version.ref = "benchmark" }
androidx-browser = { module = "androidx.browser:browser", version.ref = "androidx-browser" }
####### Compose
# You must enable the SlackProperties.enableCompose property to use these.
androidx-compose-accompanist-appCompatThemeAdapter = { module = "com.google.accompanist:accompanist-appcompat-theme", version.ref = "accompanist" }
androidx-compose-accompanist-flowlayout = { module = "com.google.accompanist:accompanist-flowlayout", version.ref = "accompanist" }
androidx-compose-accompanist-pager = { module = "com.google.accompanist:accompanist-pager", version.ref = "accompanist" }
androidx-compose-accompanist-pager-indicators = { module = "com.google.accompanist:accompanist-pager-indicators", version.ref = "accompanist" }
androidx-compose-accompanist-permissions = { module = "com.google.accompanist:accompanist-permissions", version.ref = "accompanist" }
androidx-compose-accompanist-placeholder = { module = "com.google.accompanist:accompanist-placeholder", version.ref = "accompanist" }
androidx-compose-accompanist-swiperefresh = { module = "com.google.accompanist:accompanist-swiperefresh", version.ref = "accompanist" }
androidx-compose-accompanist-systemUi = { module = "com.google.accompanist:accompanist-systemuicontroller", version.ref = "accompanist" }
androidx-compose-animation = { module = "androidx.compose.animation:animation", version.ref = "compose-animation" }
androidx-compose-bom = { module = "androidx.compose:compose-bom", version.ref = "compose-bom" }
# Foundation (Border, Background, Box, Image, Scroll, shapes, animations, etc.)
Expand Down
1 change: 0 additions & 1 deletion samples/counter/apps/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ kotlin {
implementation(libs.bundles.compose.ui)
implementation(libs.androidx.compose.integration.materialThemeAdapter)
implementation(libs.androidx.compose.material.icons)
implementation(libs.androidx.compose.accompanist.systemUi)
implementation(libs.androidx.compose.ui.tooling)
}
}
Expand Down
5 changes: 0 additions & 5 deletions samples/interop/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@ dependencies {
implementation(libs.androidx.compose.ui.util)
implementation(libs.androidx.compose.integration.materialThemeAdapter)
implementation(libs.androidx.compose.material.icons)
implementation(libs.androidx.compose.accompanist.pager)
implementation(libs.androidx.compose.accompanist.pager.indicators)
implementation(libs.androidx.compose.accompanist.flowlayout)
implementation(libs.androidx.compose.accompanist.swiperefresh)
implementation(libs.androidx.compose.accompanist.systemUi)
debugImplementation(libs.androidx.compose.ui.tooling)
implementation(libs.windowSizeClass)
implementation(libs.bundles.androidx.activity)
Expand Down
4 changes: 0 additions & 4 deletions samples/star/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,6 @@ kotlin {
implementation(libs.androidx.appCompat)
implementation(libs.androidx.activity.compose)
implementation(libs.androidx.browser)
implementation(libs.androidx.compose.accompanist.flowlayout)
implementation(libs.androidx.compose.accompanist.pager)
implementation(libs.androidx.compose.accompanist.pager.indicators)
implementation(libs.androidx.compose.accompanist.systemUi)
implementation(libs.androidx.compose.googleFonts)
implementation(libs.androidx.compose.ui.tooling)
implementation(libs.coroutines.android)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/
package com.slack.circuit.star.ui

import androidx.compose.foundation.ExperimentalFoundationApi
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
Expand Down Expand Up @@ -63,9 +62,7 @@ import kotlin.math.sign
* @param indicatorHeight the height of each indicator in [Dp]. Defaults to [indicatorWidth].
* @param spacing the spacing between each indicator in [Dp].
* @param indicatorShape the shape representing each indicator. This defaults to [CircleShape].
* @sample com.google.accompanist.sample.pager.HorizontalPagerIndicatorSample
*/
@OptIn(ExperimentalFoundationApi::class)
@Composable
fun HorizontalPagerIndicator(
pagerState: androidx.compose.foundation.pager.PagerState,
Expand Down
1 change: 0 additions & 1 deletion samples/tacos/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ dependencies {
implementation(libs.androidx.activity.ktx)
implementation(libs.androidx.activity.compose)
implementation(libs.androidx.appCompat)
implementation(libs.androidx.compose.accompanist.systemUi)
implementation(libs.androidx.compose.integration.materialThemeAdapter)
implementation(libs.androidx.compose.material.material3)
debugImplementation(libs.androidx.compose.ui.tooling)
Expand Down

0 comments on commit 2648322

Please sign in to comment.