This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
Gather all logged runs in a standard date format #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimeg
added
bug
misscoded
approved these changes
Sep 28, 2023
|
Thanks for the review @misscoded! 🚀 |
filmaj
reviewed
Sep 28, 2023
|
|
||
| cursor = runs.response_metadata?.next_cursor; | ||
| items.push(...runs.items); | ||
| } while (cursor); |
There was a problem hiding this comment.
do/while w/ cursors in Dynamo is exactly how I structure my DDB pagination calls 👍
| const isRecentRun = run.rundate >= | ||
| startOfLastWeek.toLocaleDateString("en-CA", { timeZone: "UTC" }); | ||
| const isRecentRun = | ||
| run.rundate >= startOfLastWeek.toISOString().substring(0, 10); |
There was a problem hiding this comment.
ISO-8601 just feels so much better 🙌 🙌
There was a problem hiding this comment.
ISO8601 is the best date standard IMO
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
This PR paginates over the
running_datastoredatastore to collect all logged runs and stores runs with with the ISO-8601 timestamp. Tests are also returned with a stable date to verify proper month/year wrapping when gathering past weeks.Closes #7, fixes #22, and resolved #13.
Requirements