Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(fix): check that no files were changed when performing a lint #131

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci(fix): check that no files were changed when performing a lint #131

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd502e4
temp: add an extra indent to break lintings but not logic
zimeg Nov 5, 2024
13c44a5
build: setup a separate lint and lint:fix npm job
zimeg Nov 5, 2024
fd714f5
revert: unbreak the linting indentation used for testing
zimeg Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"scripts": {
"build": "tsc",
"start": "npm run build && node ./dist/app.js",
"lint": "npx @biomejs/biome check --write *.ts listeners",
"lint": "npx @biomejs/biome check *.ts listeners",
"lint:fix": "npx @biomejs/biome check --write *.ts listeners",
Comment on lines +9 to +10
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reference to npm run lint in the README which I think is alright, but I'm unsure if the : approach makes sense here 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding npm run lint:ci and using it for CI jobs may be another option, but I'm happy to let @filmaj and you decide the naming tomorrow!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either works for me 👍

"test": "npm run build && npm run lint"
},
"author": "Slack Technologies, LLC",
Expand Down